| From aa32f9869c5943c54b623207391717064f91026d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 8 May 2021 11:13:54 +0800 |
| Subject: um: fix error return code in slip_open() |
| |
| From: Zhen Lei <thunder.leizhen@huawei.com> |
| |
| [ Upstream commit b77e81fbe5f5fb4ad9a61ec80f6d1e30b6da093a ] |
| |
| Fix to return a negative error code from the error handling case instead |
| of 0, as done elsewhere in this function. |
| |
| Fixes: a3c77c67a443 ("[PATCH] uml: slirp and slip driver cleanups and fixes") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> |
| Acked-By: anton.ivanov@cambridgegreys.com |
| Signed-off-by: Richard Weinberger <richard@nod.at> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/um/drivers/slip_user.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/arch/um/drivers/slip_user.c b/arch/um/drivers/slip_user.c |
| index 482a19c5105c..7334019c9e60 100644 |
| --- a/arch/um/drivers/slip_user.c |
| +++ b/arch/um/drivers/slip_user.c |
| @@ -145,7 +145,8 @@ static int slip_open(void *data) |
| } |
| sfd = err; |
| |
| - if (set_up_tty(sfd)) |
| + err = set_up_tty(sfd); |
| + if (err) |
| goto out_close2; |
| |
| pri->slave = sfd; |
| -- |
| 2.30.2 |
| |
