| From 87ed7617254bad29602e2107d3690f61704a0388 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 17 Jun 2021 19:27:55 +0300 |
| Subject: usb: gadget: f_hid: fix endianness issue with descriptors |
| |
| From: Ruslan Bilovol <ruslan.bilovol@gmail.com> |
| |
| [ Upstream commit 33cb46c4676d01956811b68a29157ea969a5df70 ] |
| |
| Running sparse checker it shows warning message about |
| incorrect endianness used for descriptor initialization: |
| |
| | f_hid.c:91:43: warning: incorrect type in initializer (different base types) |
| | f_hid.c:91:43: expected restricted __le16 [usertype] bcdHID |
| | f_hid.c:91:43: got int |
| |
| Fixing issue with cpu_to_le16() macro, however this is not a real issue |
| as the value is the same both endians. |
| |
| Cc: Fabien Chouteau <fabien.chouteau@barco.com> |
| Cc: Segiy Stetsyuk <serg_stetsuk@ukr.net> |
| Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com> |
| Link: https://lore.kernel.org/r/20210617162755.29676-1-ruslan.bilovol@gmail.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/usb/gadget/function/f_hid.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c |
| index e55699308117..a82b3de1a54b 100644 |
| --- a/drivers/usb/gadget/function/f_hid.c |
| +++ b/drivers/usb/gadget/function/f_hid.c |
| @@ -88,7 +88,7 @@ static struct usb_interface_descriptor hidg_interface_desc = { |
| static struct hid_descriptor hidg_desc = { |
| .bLength = sizeof hidg_desc, |
| .bDescriptorType = HID_DT_HID, |
| - .bcdHID = 0x0101, |
| + .bcdHID = cpu_to_le16(0x0101), |
| .bCountryCode = 0x00, |
| .bNumDescriptors = 0x1, |
| /*.desc[0].bDescriptorType = DYNAMIC */ |
| -- |
| 2.30.2 |
| |