| From c4a449d90c74c6f22467c4e59ba33f5466622fea Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 17 May 2021 23:19:47 +0530 |
| Subject: watchdog: keembay: Update pretimeout to zero in the TH ISR |
| |
| From: Shruthi Sanil <shruthi.sanil@intel.com> |
| |
| [ Upstream commit 75f6c56dfeec92c53e09a72896547888ac9a27d7 ] |
| |
| The pretimeout has to be updated to zero during the ISR of the |
| ThresHold interrupt. Else the TH interrupt would be triggerred for |
| every tick until the timeout. |
| |
| Fixes: fa0f8d51e90d ("watchdog: Add watchdog driver for Intel Keembay Soc") |
| Reviewed-by: Guenter Roeck <linux@roeck-us.net> |
| Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Tested-by: Kris Pan <kris.pan@intel.com> |
| Signed-off-by: Shruthi Sanil <shruthi.sanil@intel.com> |
| Link: https://lore.kernel.org/r/20210517174953.19404-4-shruthi.sanil@intel.com |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/watchdog/keembay_wdt.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/watchdog/keembay_wdt.c b/drivers/watchdog/keembay_wdt.c |
| index b2afeb4a60e3..6053416b8d3d 100644 |
| --- a/drivers/watchdog/keembay_wdt.c |
| +++ b/drivers/watchdog/keembay_wdt.c |
| @@ -154,6 +154,8 @@ static irqreturn_t keembay_wdt_th_isr(int irq, void *dev_id) |
| struct keembay_wdt *wdt = dev_id; |
| struct arm_smccc_res res; |
| |
| + keembay_wdt_set_pretimeout(&wdt->wdd, 0x0); |
| + |
| arm_smccc_smc(WDT_ISR_CLEAR, WDT_ISR_MASK, 0, 0, 0, 0, 0, 0, &res); |
| dev_crit(wdt->wdd.parent, "Intel Keem Bay non-sec wdt pre-timeout.\n"); |
| watchdog_notify_pretimeout(&wdt->wdd); |
| -- |
| 2.30.2 |
| |
