| From f30741cded62f87bb4b1cc58bc627f076abcaba8 Mon Sep 17 00:00:00 2001 |
| From: Kai-Heng Feng <kai.heng.feng@canonical.com> |
| Date: Wed, 30 Mar 2022 14:13:33 +0800 |
| Subject: ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020 |
| |
| From: Kai-Heng Feng <kai.heng.feng@canonical.com> |
| |
| commit f30741cded62f87bb4b1cc58bc627f076abcaba8 upstream. |
| |
| Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording |
| issue") is to solve recording issue met on AL236, by matching codec |
| variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256. |
| |
| This match can be too broad and Mi Notebook Pro 2020 is broken by the |
| patch. |
| |
| Instead, use codec ID to be narrow down the scope, in order to make |
| ALC256 unaffected. |
| |
| Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484 |
| Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue") |
| Reported-by: kernel test robot <lkp@intel.com> |
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Cc: <stable@vger.kernel.org> |
| Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> |
| Link: https://lore.kernel.org/r/20220330061335.1015533-1-kai.heng.feng@canonical.com |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| sound/pci/hda/patch_realtek.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/sound/pci/hda/patch_realtek.c |
| +++ b/sound/pci/hda/patch_realtek.c |
| @@ -3612,8 +3612,8 @@ static void alc256_shutup(struct hda_cod |
| /* If disable 3k pulldown control for alc257, the Mic detection will not work correctly |
| * when booting with headset plugged. So skip setting it for the codec alc257 |
| */ |
| - if (spec->codec_variant != ALC269_TYPE_ALC257 && |
| - spec->codec_variant != ALC269_TYPE_ALC256) |
| + if (codec->core.vendor_id != 0x10ec0236 && |
| + codec->core.vendor_id != 0x10ec0257) |
| alc_update_coef_idx(codec, 0x46, 0, 3 << 12); |
| |
| if (!spec->no_shutup_pins) |