| From 1cfcc3a2d0e17b506ad03ee74e06b4b67e6c2ac3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 28 Jan 2022 17:19:44 +0800 |
| Subject: drm/imx: dw_hdmi-imx: Fix bailout in error cases of probe |
| |
| From: Liu Ying <victor.liu@nxp.com> |
| |
| [ Upstream commit e8083acc3f8cc2097917018e947fd4c857f60454 ] |
| |
| In dw_hdmi_imx_probe(), if error happens after dw_hdmi_probe() returns |
| successfully, dw_hdmi_remove() should be called where necessary as |
| bailout. |
| |
| Fixes: c805ec7eb210 ("drm/imx: dw_hdmi-imx: move initialization into probe") |
| Cc: Philipp Zabel <p.zabel@pengutronix.de> |
| Cc: David Airlie <airlied@linux.ie> |
| Cc: Daniel Vetter <daniel@ffwll.ch> |
| Cc: Shawn Guo <shawnguo@kernel.org> |
| Cc: Sascha Hauer <s.hauer@pengutronix.de> |
| Cc: Pengutronix Kernel Team <kernel@pengutronix.de> |
| Cc: Fabio Estevam <festevam@gmail.com> |
| Cc: NXP Linux Team <linux-imx@nxp.com> |
| Signed-off-by: Liu Ying <victor.liu@nxp.com> |
| Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> |
| Link: https://lore.kernel.org/r/20220128091944.3831256-1-victor.liu@nxp.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/imx/dw_hdmi-imx.c | 8 +++++++- |
| 1 file changed, 7 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/imx/dw_hdmi-imx.c b/drivers/gpu/drm/imx/dw_hdmi-imx.c |
| index 87428fb23d9f..a2277a0d6d06 100644 |
| --- a/drivers/gpu/drm/imx/dw_hdmi-imx.c |
| +++ b/drivers/gpu/drm/imx/dw_hdmi-imx.c |
| @@ -222,6 +222,7 @@ static int dw_hdmi_imx_probe(struct platform_device *pdev) |
| struct device_node *np = pdev->dev.of_node; |
| const struct of_device_id *match = of_match_node(dw_hdmi_imx_dt_ids, np); |
| struct imx_hdmi *hdmi; |
| + int ret; |
| |
| hdmi = devm_kzalloc(&pdev->dev, sizeof(*hdmi), GFP_KERNEL); |
| if (!hdmi) |
| @@ -243,10 +244,15 @@ static int dw_hdmi_imx_probe(struct platform_device *pdev) |
| hdmi->bridge = of_drm_find_bridge(np); |
| if (!hdmi->bridge) { |
| dev_err(hdmi->dev, "Unable to find bridge\n"); |
| + dw_hdmi_remove(hdmi->hdmi); |
| return -ENODEV; |
| } |
| |
| - return component_add(&pdev->dev, &dw_hdmi_imx_ops); |
| + ret = component_add(&pdev->dev, &dw_hdmi_imx_ops); |
| + if (ret) |
| + dw_hdmi_remove(hdmi->hdmi); |
| + |
| + return ret; |
| } |
| |
| static int dw_hdmi_imx_remove(struct platform_device *pdev) |
| -- |
| 2.35.1 |
| |