| From b2c053137218af1a7ae8211aabb2345cce4088b2 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 3 Jan 2022 09:48:27 +0200 |
| Subject: habanalabs: fix possible memory leak in MMU DR fini |
| |
| From: Ohad Sharabi <osharabi@habana.ai> |
| |
| [ Upstream commit eb85eec858c1a5c11d3a0bff403f6440b05b40dc ] |
| |
| This patch fixes what seems to be copy paste error. |
| |
| We will have a memory leak if the host-resident shadow is NULL (which |
| will likely happen as the DR and HR are not dependent). |
| |
| Signed-off-by: Ohad Sharabi <osharabi@habana.ai> |
| Reviewed-by: Oded Gabbay <ogabbay@kernel.org> |
| Signed-off-by: Oded Gabbay <ogabbay@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/misc/habanalabs/common/mmu/mmu_v1.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/misc/habanalabs/common/mmu/mmu_v1.c b/drivers/misc/habanalabs/common/mmu/mmu_v1.c |
| index 0f536f79dd9c..e68e9f71c546 100644 |
| --- a/drivers/misc/habanalabs/common/mmu/mmu_v1.c |
| +++ b/drivers/misc/habanalabs/common/mmu/mmu_v1.c |
| @@ -467,7 +467,7 @@ static void hl_mmu_v1_fini(struct hl_device *hdev) |
| { |
| /* MMU H/W fini was already done in device hw_fini() */ |
| |
| - if (!ZERO_OR_NULL_PTR(hdev->mmu_priv.hr.mmu_shadow_hop0)) { |
| + if (!ZERO_OR_NULL_PTR(hdev->mmu_priv.dr.mmu_shadow_hop0)) { |
| kvfree(hdev->mmu_priv.dr.mmu_shadow_hop0); |
| gen_pool_destroy(hdev->mmu_priv.dr.mmu_pgt_pool); |
| |
| -- |
| 2.35.1 |
| |
