| From d4ec840971aa6ef2ab0440bb2c3245afbdcc7646 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 6 Apr 2022 12:43:57 +0100 |
| Subject: io_uring: nospec index for tags on files update |
| |
| From: Pavel Begunkov <asml.silence@gmail.com> |
| |
| [ Upstream commit 34bb77184123ae401100a4d156584f12fa630e5c ] |
| |
| Don't forget to array_index_nospec() for indexes before updating rsrc |
| tags in __io_sqe_files_update(), just use already safe and precalculated |
| index @i. |
| |
| Fixes: c3bdad0271834 ("io_uring: add generic rsrc update with tags") |
| Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> |
| Signed-off-by: Jens Axboe <axboe@kernel.dk> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/io_uring.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/fs/io_uring.c b/fs/io_uring.c |
| index 49cafa0a8b8f..c744b9910d9e 100644 |
| --- a/fs/io_uring.c |
| +++ b/fs/io_uring.c |
| @@ -8640,7 +8640,7 @@ static int __io_sqe_files_update(struct io_ring_ctx *ctx, |
| err = -EBADF; |
| break; |
| } |
| - *io_get_tag_slot(data, up->offset + done) = tag; |
| + *io_get_tag_slot(data, i) = tag; |
| io_fixed_file_set(file_slot, file); |
| err = io_sqe_file_register(ctx, file, i); |
| if (err) { |
| -- |
| 2.35.1 |
| |