| From 9892d95b8efa8d18aca3939dc36b1f22c58c2f3c Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 1 Apr 2022 10:48:42 +0800 |
| Subject: mctp: Fix check for dev_hard_header() result |
| |
| From: Matt Johnston <matt@codeconstruct.com.au> |
| |
| [ Upstream commit 60be976ac45137657b7b505d7e0d44d0e51accb7 ] |
| |
| dev_hard_header() returns the length of the header, so |
| we need to test for negative errors rather than non-zero. |
| |
| Fixes: 889b7da23abf ("mctp: Add initial routing framework") |
| Signed-off-by: Matt Johnston <matt@codeconstruct.com.au> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| net/mctp/route.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/net/mctp/route.c b/net/mctp/route.c |
| index f8c0cb2de98b..d1e93b7f67d2 100644 |
| --- a/net/mctp/route.c |
| +++ b/net/mctp/route.c |
| @@ -509,7 +509,7 @@ static int mctp_route_output(struct mctp_route *route, struct sk_buff *skb) |
| |
| rc = dev_hard_header(skb, skb->dev, ntohs(skb->protocol), |
| daddr, skb->dev->dev_addr, skb->len); |
| - if (rc) { |
| + if (rc < 0) { |
| kfree_skb(skb); |
| return -EHOSTUNREACH; |
| } |
| -- |
| 2.35.1 |
| |
