| From 8cd3377e44bb310723fa978a9d667f269a67484b Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 25 Jan 2022 21:10:45 +0800 |
| Subject: NFSv4.2: fix reference count leaks in _nfs42_proc_copy_notify() |
| |
| From: Xin Xiong <xiongx18@fudan.edu.cn> |
| |
| [ Upstream commit b7f114edd54326f730a754547e7cfb197b5bc132 ] |
| |
| [You don't often get email from xiongx18@fudan.edu.cn. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.] |
| |
| The reference counting issue happens in two error paths in the |
| function _nfs42_proc_copy_notify(). In both error paths, the function |
| simply returns the error code and forgets to balance the refcount of |
| object `ctx`, bumped by get_nfs_open_context() earlier, which may |
| cause refcount leaks. |
| |
| Fix it by balancing refcount of the `ctx` object before the function |
| returns in both error paths. |
| |
| Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn> |
| Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn> |
| Signed-off-by: Xin Tan <tanxin.ctf@gmail.com> |
| Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/nfs/nfs42proc.c | 9 ++++++--- |
| 1 file changed, 6 insertions(+), 3 deletions(-) |
| |
| diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c |
| index 8b21ff1be717..438de4f93ce7 100644 |
| --- a/fs/nfs/nfs42proc.c |
| +++ b/fs/nfs/nfs42proc.c |
| @@ -592,8 +592,10 @@ static int _nfs42_proc_copy_notify(struct file *src, struct file *dst, |
| |
| ctx = get_nfs_open_context(nfs_file_open_context(src)); |
| l_ctx = nfs_get_lock_context(ctx); |
| - if (IS_ERR(l_ctx)) |
| - return PTR_ERR(l_ctx); |
| + if (IS_ERR(l_ctx)) { |
| + status = PTR_ERR(l_ctx); |
| + goto out; |
| + } |
| |
| status = nfs4_set_rw_stateid(&args->cna_src_stateid, ctx, l_ctx, |
| FMODE_READ); |
| @@ -601,7 +603,7 @@ static int _nfs42_proc_copy_notify(struct file *src, struct file *dst, |
| if (status) { |
| if (status == -EAGAIN) |
| status = -NFS4ERR_BAD_STATEID; |
| - return status; |
| + goto out; |
| } |
| |
| status = nfs4_call_sync(src_server->client, src_server, &msg, |
| @@ -610,6 +612,7 @@ static int _nfs42_proc_copy_notify(struct file *src, struct file *dst, |
| if (status == -ENOTSUPP) |
| src_server->caps &= ~NFS_CAP_COPY_NOTIFY; |
| |
| +out: |
| put_nfs_open_context(nfs_file_open_context(src)); |
| return status; |
| } |
| -- |
| 2.35.1 |
| |