| From dc35aa93deb32f7bd4e5724f0984c3cd5c1e16c8 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 27 Jan 2022 08:02:36 +0800 |
| Subject: ptp: replace snprintf with sysfs_emit |
| |
| From: Yang Guang <yang.guang5@zte.com.cn> |
| |
| [ Upstream commit e2cf07654efb0fd7bbcb475c6f74be7b5755a8fd ] |
| |
| coccinelle report: |
| ./drivers/ptp/ptp_sysfs.c:17:8-16: |
| WARNING: use scnprintf or sprintf |
| ./drivers/ptp/ptp_sysfs.c:390:8-16: |
| WARNING: use scnprintf or sprintf |
| |
| Use sysfs_emit instead of scnprintf or sprintf makes more sense. |
| |
| Reported-by: Zeal Robot <zealci@zte.com.cn> |
| Signed-off-by: Yang Guang <yang.guang5@zte.com.cn> |
| Signed-off-by: David Yang <davidcomponentone@gmail.com> |
| Acked-by: Richard Cochran <richardcochran@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/ptp/ptp_sysfs.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sysfs.c |
| index 41b92dc2f011..9233bfedeb17 100644 |
| --- a/drivers/ptp/ptp_sysfs.c |
| +++ b/drivers/ptp/ptp_sysfs.c |
| @@ -14,7 +14,7 @@ static ssize_t clock_name_show(struct device *dev, |
| struct device_attribute *attr, char *page) |
| { |
| struct ptp_clock *ptp = dev_get_drvdata(dev); |
| - return snprintf(page, PAGE_SIZE-1, "%s\n", ptp->info->name); |
| + return sysfs_emit(page, "%s\n", ptp->info->name); |
| } |
| static DEVICE_ATTR_RO(clock_name); |
| |
| @@ -387,7 +387,7 @@ static ssize_t ptp_pin_show(struct device *dev, struct device_attribute *attr, |
| |
| mutex_unlock(&ptp->pincfg_mux); |
| |
| - return snprintf(page, PAGE_SIZE, "%u %u\n", func, chan); |
| + return sysfs_emit(page, "%u %u\n", func, chan); |
| } |
| |
| static ssize_t ptp_pin_store(struct device *dev, struct device_attribute *attr, |
| -- |
| 2.35.1 |
| |