| From 20921c0c86092b4082c91bd7c88305da74e5520b Mon Sep 17 00:00:00 2001 |
| From: Manish Chopra <manishc@marvell.com> |
| Date: Fri, 1 Apr 2022 11:53:04 -0700 |
| Subject: qed: fix ethtool register dump |
| |
| From: Manish Chopra <manishc@marvell.com> |
| |
| commit 20921c0c86092b4082c91bd7c88305da74e5520b upstream. |
| |
| To fix a coverity complain, commit d5ac07dfbd2b |
| ("qed: Initialize debug string array") removed "sw-platform" |
| (one of the common global parameters) from the dump as this |
| was used in the dump with an uninitialized string, however |
| it did not reduce the number of common global parameters |
| which caused the incorrect (unable to parse) register dump |
| |
| this patch fixes it with reducing NUM_COMMON_GLOBAL_PARAMS |
| bye one. |
| |
| Cc: stable@vger.kernel.org |
| Cc: Tim Gardner <tim.gardner@canonical.com> |
| Cc: "David S. Miller" <davem@davemloft.net> |
| Fixes: d5ac07dfbd2b ("qed: Initialize debug string array") |
| Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com> |
| Signed-off-by: Alok Prasad <palok@marvell.com> |
| Signed-off-by: Ariel Elior <aelior@marvell.com> |
| Signed-off-by: Manish Chopra <manishc@marvell.com> |
| Reviewed-by: Tim Gardner <tim.gardner@canonical.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/qlogic/qed/qed_debug.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c |
| +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c |
| @@ -489,7 +489,7 @@ struct split_type_defs { |
| |
| #define STATIC_DEBUG_LINE_DWORDS 9 |
| |
| -#define NUM_COMMON_GLOBAL_PARAMS 11 |
| +#define NUM_COMMON_GLOBAL_PARAMS 10 |
| |
| #define MAX_RECURSION_DEPTH 10 |
| |