| From b54d788e7243abaaa1834b7788414c8cf3bd49c2 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 10 Dec 2021 21:01:24 +0100 |
| Subject: rtc: mc146818-lib: change return values of mc146818_get_time() |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Mateusz Jończyk <mat.jonczyk@o2.pl> |
| |
| [ Upstream commit d35786b3a28dee20b12962ae2dd365892a99ed1a ] |
| |
| No function is checking mc146818_get_time() return values yet, so |
| correct them to make them more customary. |
| |
| Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl> |
| Cc: Alessandro Zummo <a.zummo@towertech.it> |
| Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> |
| Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> |
| Link: https://lore.kernel.org/r/20211210200131.153887-3-mat.jonczyk@o2.pl |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/rtc/rtc-mc146818-lib.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/rtc/rtc-mc146818-lib.c b/drivers/rtc/rtc-mc146818-lib.c |
| index 04b05e3b68cb..bd48cee3027e 100644 |
| --- a/drivers/rtc/rtc-mc146818-lib.c |
| +++ b/drivers/rtc/rtc-mc146818-lib.c |
| @@ -25,7 +25,7 @@ unsigned int mc146818_get_time(struct rtc_time *time) |
| if (WARN_ON_ONCE((CMOS_READ(RTC_VALID) & 0x40) != 0)) { |
| spin_unlock_irqrestore(&rtc_lock, flags); |
| memset(time, 0xff, sizeof(*time)); |
| - return 0; |
| + return -EIO; |
| } |
| |
| /* |
| @@ -116,7 +116,7 @@ unsigned int mc146818_get_time(struct rtc_time *time) |
| |
| time->tm_mon--; |
| |
| - return RTC_24H; |
| + return 0; |
| } |
| EXPORT_SYMBOL_GPL(mc146818_get_time); |
| |
| -- |
| 2.35.1 |
| |
