| From 7d7e3d0d4b98ba732f365372695570d021a39d92 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 20 Feb 2022 12:18:01 +0900 |
| Subject: scsi: pm8001: Fix memory leak in pm8001_chip_fw_flash_update_req() |
| |
| From: Damien Le Moal <damien.lemoal@opensource.wdc.com> |
| |
| [ Upstream commit f792a3629f4c4aa4c3703d66b43ce1edcc3ec09a ] |
| |
| In pm8001_chip_fw_flash_update_build(), if |
| pm8001_chip_fw_flash_update_build() fails, the struct fw_control_ex |
| allocated must be freed. |
| |
| Link: https://lore.kernel.org/r/20220220031810.738362-23-damien.lemoal@opensource.wdc.com |
| Reviewed-by: Jack Wang <jinpu.wang@ionos.com> |
| Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/scsi/pm8001/pm8001_hwi.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c |
| index e447b714df2b..1a5338917a89 100644 |
| --- a/drivers/scsi/pm8001/pm8001_hwi.c |
| +++ b/drivers/scsi/pm8001/pm8001_hwi.c |
| @@ -4907,8 +4907,10 @@ pm8001_chip_fw_flash_update_req(struct pm8001_hba_info *pm8001_ha, |
| ccb->ccb_tag = tag; |
| rc = pm8001_chip_fw_flash_update_build(pm8001_ha, &flash_update_info, |
| tag); |
| - if (rc) |
| + if (rc) { |
| + kfree(fw_control_context); |
| pm8001_tag_free(pm8001_ha, tag); |
| + } |
| |
| return rc; |
| } |
| -- |
| 2.35.1 |
| |
