| From d3324e69a462e86f775edbcc79645863b5c5e737 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 1 Feb 2022 15:47:53 -0600 |
| Subject: scsi: smartpqi: Fix rmmod stack trace |
| |
| From: Don Brace <don.brace@microchip.com> |
| |
| [ Upstream commit c4ff687d25c05919382a759503bd3821689f4e2f ] |
| |
| Prevent "BUG: scheduling while atomic: rmmod" stack trace. |
| |
| Stop setting spin_locks before calling OS functions to remove devices. |
| |
| Link: https://lore.kernel.org/r/164375207296.440833.4996145011193819683.stgit@brunhilda.pdev.net |
| Reviewed-by: Scott Benesh <scott.benesh@microchip.com> |
| Reviewed-by: Scott Teel <scott.teel@microchip.com> |
| Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com> |
| Signed-off-by: Don Brace <don.brace@microchip.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/scsi/smartpqi/smartpqi_init.c | 6 ++---- |
| 1 file changed, 2 insertions(+), 4 deletions(-) |
| |
| diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c |
| index f0897d587454..2db9f874cc51 100644 |
| --- a/drivers/scsi/smartpqi/smartpqi_init.c |
| +++ b/drivers/scsi/smartpqi/smartpqi_init.c |
| @@ -2513,17 +2513,15 @@ static void pqi_remove_all_scsi_devices(struct pqi_ctrl_info *ctrl_info) |
| struct pqi_scsi_dev *device; |
| struct pqi_scsi_dev *next; |
| |
| - spin_lock_irqsave(&ctrl_info->scsi_device_list_lock, flags); |
| - |
| list_for_each_entry_safe(device, next, &ctrl_info->scsi_device_list, |
| scsi_device_list_entry) { |
| if (pqi_is_device_added(device)) |
| pqi_remove_device(ctrl_info, device); |
| + spin_lock_irqsave(&ctrl_info->scsi_device_list_lock, flags); |
| list_del(&device->scsi_device_list_entry); |
| pqi_free_device(device); |
| + spin_unlock_irqrestore(&ctrl_info->scsi_device_list_lock, flags); |
| } |
| - |
| - spin_unlock_irqrestore(&ctrl_info->scsi_device_list_lock, flags); |
| } |
| |
| static int pqi_scan_scsi_devices(struct pqi_ctrl_info *ctrl_info) |
| -- |
| 2.35.1 |
| |
