| From 64bbacc5f08c01954890981c63de744df1f29a30 Mon Sep 17 00:00:00 2001 |
| From: Takashi Iwai <tiwai@suse.de> |
| Date: Tue, 18 Feb 2020 12:17:35 +0100 |
| Subject: ASoC: intel: skl: Fix pin debug prints |
| |
| From: Takashi Iwai <tiwai@suse.de> |
| |
| commit 64bbacc5f08c01954890981c63de744df1f29a30 upstream. |
| |
| skl_print_pins() loops over all given pins but it overwrites the text |
| at the very same position while increasing the returned length. |
| Fix this to show the all pin contents properly. |
| |
| Fixes: d14700a01f91 ("ASoC: Intel: Skylake: Debugfs facility to dump module config") |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Acked-by: Cezary Rojewski <cezary.rojewski@intel.com> |
| Link: https://lore.kernel.org/r/20200218111737.14193-2-tiwai@suse.de |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| sound/soc/intel/skylake/skl-debug.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/sound/soc/intel/skylake/skl-debug.c |
| +++ b/sound/soc/intel/skylake/skl-debug.c |
| @@ -34,7 +34,7 @@ static ssize_t skl_print_pins(struct skl |
| int i; |
| ssize_t ret = 0; |
| |
| - for (i = 0; i < max_pin; i++) |
| + for (i = 0; i < max_pin; i++) { |
| ret += snprintf(buf + size, MOD_BUF - size, |
| "%s %d\n\tModule %d\n\tInstance %d\n\t" |
| "In-used %s\n\tType %s\n" |
| @@ -45,6 +45,8 @@ static ssize_t skl_print_pins(struct skl |
| m_pin[i].in_use ? "Used" : "Unused", |
| m_pin[i].is_dynamic ? "Dynamic" : "Static", |
| m_pin[i].pin_state, i); |
| + size += ret; |
| + } |
| return ret; |
| } |
| |