| From 7216a1b71749df2da9aa124c430adff90fe936b3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 23 Jan 2020 00:43:06 +0200 |
| Subject: habanalabs: patched cb equals user cb in device memset |
| |
| From: Oded Gabbay <oded.gabbay@gmail.com> |
| |
| [ Upstream commit cf01514c5c6efa2d521d35e68dff2e0674d08e91 ] |
| |
| During device memory memset, the driver allocates and use a CB (command |
| buffer). To reuse existing code, it keeps a pointer to the CB in two |
| variables, user_cb and patched_cb. Therefore, there is no need to "put" |
| both the user_cb and patched_cb, as it will cause an underflow of the |
| refcnt of the CB. |
| |
| Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/misc/habanalabs/goya/goya.c | 2 -- |
| 1 file changed, 2 deletions(-) |
| |
| diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c |
| index f24fe909b88d8..b8a8de24aaf72 100644 |
| --- a/drivers/misc/habanalabs/goya/goya.c |
| +++ b/drivers/misc/habanalabs/goya/goya.c |
| @@ -4690,8 +4690,6 @@ static int goya_memset_device_memory(struct hl_device *hdev, u64 addr, u64 size, |
| |
| rc = goya_send_job_on_qman0(hdev, job); |
| |
| - hl_cb_put(job->patched_cb); |
| - |
| hl_debugfs_remove_job(hdev, job); |
| kfree(job); |
| cb->cs_cnt--; |
| -- |
| 2.20.1 |
| |
