| From 06436d8d1dd8bcd678aee4b48b0fb425cd9a48c1 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 13 Feb 2020 13:31:24 -0800 |
| Subject: ice: Don't tell the OS that link is going down |
| |
| From: Michal Swiatkowski <michal.swiatkowski@intel.com> |
| |
| [ Upstream commit 8a55c08d3bbc9ffc9639f69f742e59ebd99f913b ] |
| |
| Remove code that tell the OS that link is going down when user |
| change flow control via ethtool. When link is up it isn't certain |
| that link goes down after 0x0605 aq command. If link doesn't go |
| down, OS thinks that link is down, but physical link is up. To |
| reset this state user have to take interface down and up. |
| |
| If link goes down after 0x0605 command, FW send information |
| about that and after that driver tells the OS that the link goes |
| down. So this code in ethtool is unnecessary. |
| |
| Signed-off-by: Michal Swiatkowski <michal.swiatkowski@intel.com> |
| Tested-by: Andrew Bowers <andrewx.bowers@intel.com> |
| Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 ------- |
| 1 file changed, 7 deletions(-) |
| |
| diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c |
| index 9bd166e3dff3d..594f6dbb21102 100644 |
| --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c |
| +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c |
| @@ -2977,13 +2977,6 @@ ice_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause) |
| else |
| return -EINVAL; |
| |
| - /* Tell the OS link is going down, the link will go back up when fw |
| - * says it is ready asynchronously |
| - */ |
| - ice_print_link_msg(vsi, false); |
| - netif_carrier_off(netdev); |
| - netif_tx_stop_all_queues(netdev); |
| - |
| /* Set the FC mode and only restart AN if link is up */ |
| status = ice_set_fc(pi, &aq_failures, link_up); |
| |
| -- |
| 2.20.1 |
| |
