| From 4a3e208474204e879d22a310b244cb2f39e5b1f8 Mon Sep 17 00:00:00 2001 |
| From: tangbin <tangbin@cmss.chinamobile.com> |
| Date: Thu, 5 Mar 2020 09:38:23 +0800 |
| Subject: tty:serial:mvebu-uart:fix a wrong return |
| |
| From: tangbin <tangbin@cmss.chinamobile.com> |
| |
| commit 4a3e208474204e879d22a310b244cb2f39e5b1f8 upstream. |
| |
| in this place, the function should return a |
| negative value and the PTR_ERR already returns |
| a negative,so return -PTR_ERR() is wrong. |
| |
| Signed-off-by: tangbin <tangbin@cmss.chinamobile.com> |
| Cc: stable <stable@vger.kernel.org> |
| Acked-by: Jiri Slaby <jslaby@suse.cz> |
| Link: https://lore.kernel.org/r/20200305013823.20976-1-tangbin@cmss.chinamobile.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/tty/serial/mvebu-uart.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/tty/serial/mvebu-uart.c |
| +++ b/drivers/tty/serial/mvebu-uart.c |
| @@ -851,7 +851,7 @@ static int mvebu_uart_probe(struct platf |
| |
| port->membase = devm_ioremap_resource(&pdev->dev, reg); |
| if (IS_ERR(port->membase)) |
| - return -PTR_ERR(port->membase); |
| + return PTR_ERR(port->membase); |
| |
| mvuart = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_uart), |
| GFP_KERNEL); |