| From e1f9e0d28ff025564dfdb1001a7839b4af5db2e2 Mon Sep 17 00:00:00 2001 |
| From: Tero Kristo <t-kristo@ti.com> |
| Date: Fri, 24 Apr 2020 15:47:25 +0300 |
| Subject: clk: ti: clkctrl: Fix Bad of_node_put within clkctrl_get_name |
| |
| From: Tero Kristo <t-kristo@ti.com> |
| |
| commit e1f9e0d28ff025564dfdb1001a7839b4af5db2e2 upstream. |
| |
| clkctrl_get_name incorrectly calls of_node_put when it is not really |
| doing of_node_get. This causes a boot time warning later on: |
| |
| [ 0.000000] OF: ERROR: Bad of_node_put() on /ocp/interconnect@4a000000/segmen |
| t@0/target-module@5000/cm_core_aon@0/ipu-cm@500/ipu1-clkctrl@20 |
| |
| Fix by dropping the of_node_put from the function. |
| |
| Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> |
| Fixes: 6c3090520554 ("clk: ti: clkctrl: Fix hidden dependency to node name") |
| Signed-off-by: Tero Kristo <t-kristo@ti.com> |
| Link: https://lkml.kernel.org/r/20200424124725.9895-1-t-kristo@ti.com |
| Acked-by: Tony Lindgren <tony@atomide.com> |
| Signed-off-by: Stephen Boyd <sboyd@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/clk/ti/clkctrl.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| --- a/drivers/clk/ti/clkctrl.c |
| +++ b/drivers/clk/ti/clkctrl.c |
| @@ -461,7 +461,6 @@ static char * __init clkctrl_get_name(st |
| return name; |
| } |
| } |
| - of_node_put(np); |
| |
| return NULL; |
| } |
