| From 35c1745abf5776876e50e7feef6eeeeda887452d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 19 Apr 2020 18:49:09 +0200 |
| Subject: dmaengine: mmp_tdma: Reset channel error on release |
| |
| From: Lubomir Rintel <lkundrak@v3.sk> |
| |
| [ Upstream commit 0c89446379218698189a47871336cb30286a7197 ] |
| |
| When a channel configuration fails, the status of the channel is set to |
| DEV_ERROR so that an attempt to submit it fails. However, this status |
| sticks until the heat end of the universe, making it impossible to |
| recover from the error. |
| |
| Let's reset it when the channel is released so that further use of the |
| channel with correct configuration is not impacted. |
| |
| Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> |
| Link: https://lore.kernel.org/r/20200419164912.670973-5-lkundrak@v3.sk |
| Signed-off-by: Vinod Koul <vkoul@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/dma/mmp_tdma.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c |
| index 51e08c16756ae..d683232d7fea0 100644 |
| --- a/drivers/dma/mmp_tdma.c |
| +++ b/drivers/dma/mmp_tdma.c |
| @@ -363,6 +363,8 @@ static void mmp_tdma_free_descriptor(struct mmp_tdma_chan *tdmac) |
| gen_pool_free(gpool, (unsigned long)tdmac->desc_arr, |
| size); |
| tdmac->desc_arr = NULL; |
| + if (tdmac->status == DMA_ERROR) |
| + tdmac->status = DMA_COMPLETE; |
| |
| return; |
| } |
| -- |
| 2.20.1 |
| |
