| From aa2009d59f92cfd0b38e1596be49370045fa2b17 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 29 Apr 2020 12:34:36 +0300 |
| Subject: drm/qxl: lost qxl_bo_kunmap_atomic_page in qxl_image_init_helper() |
| |
| From: Vasily Averin <vvs@virtuozzo.com> |
| |
| [ Upstream commit 5b5703dbafae74adfbe298a56a81694172caf5e6 ] |
| |
| v2: removed TODO reminder |
| |
| Signed-off-by: Vasily Averin <vvs@virtuozzo.com> |
| Link: http://patchwork.freedesktop.org/patch/msgid/a4e0ae09-a73c-1c62-04ef-3f990d41bea9@virtuozzo.com |
| Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/qxl/qxl_image.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/qxl/qxl_image.c b/drivers/gpu/drm/qxl/qxl_image.c |
| index 43688ecdd8a04..60ab7151b84dc 100644 |
| --- a/drivers/gpu/drm/qxl/qxl_image.c |
| +++ b/drivers/gpu/drm/qxl/qxl_image.c |
| @@ -212,7 +212,8 @@ qxl_image_init_helper(struct qxl_device *qdev, |
| break; |
| default: |
| DRM_ERROR("unsupported image bit depth\n"); |
| - return -EINVAL; /* TODO: cleanup */ |
| + qxl_bo_kunmap_atomic_page(qdev, image_bo, ptr); |
| + return -EINVAL; |
| } |
| image->u.bitmap.flags = QXL_BITMAP_TOP_DOWN; |
| image->u.bitmap.x = width; |
| -- |
| 2.20.1 |
| |
