| From cc973071cce6d361d542a0b6e74bd8db90685fe0 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 22 Apr 2020 12:22:11 +0300 |
| Subject: i40iw: Fix error handling in i40iw_manage_arp_cache() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit 37e31d2d26a4124506c24e95434e9baf3405a23a ] |
| |
| The i40iw_arp_table() function can return -EOVERFLOW if |
| i40iw_alloc_resource() fails so we can't just test for "== -1". |
| |
| Fixes: 4e9042e647ff ("i40iw: add hw and utils files") |
| Link: https://lore.kernel.org/r/20200422092211.GA195357@mwanda |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Acked-by: Shiraz Saleem <shiraz.saleem@intel.com> |
| Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/infiniband/hw/i40iw/i40iw_hw.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/infiniband/hw/i40iw/i40iw_hw.c b/drivers/infiniband/hw/i40iw/i40iw_hw.c |
| index 55a1fbf0e670c..ae8b97c306657 100644 |
| --- a/drivers/infiniband/hw/i40iw/i40iw_hw.c |
| +++ b/drivers/infiniband/hw/i40iw/i40iw_hw.c |
| @@ -534,7 +534,7 @@ void i40iw_manage_arp_cache(struct i40iw_device *iwdev, |
| int arp_index; |
| |
| arp_index = i40iw_arp_table(iwdev, ip_addr, ipv4, mac_addr, action); |
| - if (arp_index == -1) |
| + if (arp_index < 0) |
| return; |
| cqp_request = i40iw_get_cqp_request(&iwdev->cqp, false); |
| if (!cqp_request) |
| -- |
| 2.20.1 |
| |
