| From de08290fb287af9c6fb9130a5e4e4dd0b561c7b9 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 14 Apr 2020 02:37:26 +0200 |
| Subject: pinctrl: qcom: fix wrong write in update_dual_edge |
| |
| From: Ansuel Smith <ansuelsmth@gmail.com> |
| |
| [ Upstream commit 90bcb0c3ca0809d1ed358bfbf838df4b3d4e58e0 ] |
| |
| Fix a typo in the readl/writel accessor conversion where val is used |
| instead of pol changing the behavior of the original code. |
| |
| Cc: stable@vger.kernel.org |
| Fixes: 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors |
| Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> |
| Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> |
| Link: https://lore.kernel.org/r/20200414003726.25347-1-ansuelsmth@gmail.com |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pinctrl/qcom/pinctrl-msm.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c |
| index 1a948c3f54b7c..9f1c9951949ea 100644 |
| --- a/drivers/pinctrl/qcom/pinctrl-msm.c |
| +++ b/drivers/pinctrl/qcom/pinctrl-msm.c |
| @@ -692,7 +692,7 @@ static void msm_gpio_update_dual_edge_pos(struct msm_pinctrl *pctrl, |
| |
| pol = msm_readl_intr_cfg(pctrl, g); |
| pol ^= BIT(g->intr_polarity_bit); |
| - msm_writel_intr_cfg(val, pctrl, g); |
| + msm_writel_intr_cfg(pol, pctrl, g); |
| |
| val2 = msm_readl_io(pctrl, g) & BIT(g->in_bit); |
| intstat = msm_readl_intr_status(pctrl, g); |
| -- |
| 2.20.1 |
| |
