| From 99d39e6dc59311f57ab005f408d70b1a75664623 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 9 May 2020 14:07:13 -0400 |
| Subject: SUNRPC: Signalled ASYNC tasks need to exit |
| |
| From: Chuck Lever <chuck.lever@oracle.com> |
| |
| [ Upstream commit ce99aa62e1eb793e259d023c7f6ccb7c4879917b ] |
| |
| Ensure that signalled ASYNC rpc_tasks exit immediately instead of |
| spinning until a timeout (or forever). |
| |
| To avoid checking for the signal flag on every scheduler iteration, |
| the check is instead introduced in the client's finite state |
| machine. |
| |
| Signed-off-by: Chuck Lever <chuck.lever@oracle.com> |
| Fixes: ae67bd3821bb ("SUNRPC: Fix up task signalling") |
| Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| net/sunrpc/clnt.c | 5 +++++ |
| 1 file changed, 5 insertions(+) |
| |
| diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c |
| index 7324b21f923e6..3ceaefb2f0bcf 100644 |
| --- a/net/sunrpc/clnt.c |
| +++ b/net/sunrpc/clnt.c |
| @@ -2416,6 +2416,11 @@ rpc_check_timeout(struct rpc_task *task) |
| { |
| struct rpc_clnt *clnt = task->tk_client; |
| |
| + if (RPC_SIGNALLED(task)) { |
| + rpc_call_rpcerror(task, -ERESTARTSYS); |
| + return; |
| + } |
| + |
| if (xprt_adjust_timeout(task->tk_rqstp) == 0) |
| return; |
| |
| -- |
| 2.20.1 |
| |