| From 1035a9e3e9c76b64a860a774f5b867d28d34acc2 Mon Sep 17 00:00:00 2001 |
| From: Axel Lin <axel.lin@ingics.com> |
| Date: Wed, 2 Jul 2014 08:29:55 +0800 |
| Subject: hwmon: (adm1029) Ensure the fan_div cache is updated in set_fan_div |
| |
| From: Axel Lin <axel.lin@ingics.com> |
| |
| commit 1035a9e3e9c76b64a860a774f5b867d28d34acc2 upstream. |
| |
| Writing to fanX_div does not clear the cache. As a result, reading |
| from fanX_div may return the old value for up to two seconds |
| after writing a new value. |
| |
| This patch ensures the fan_div cache is updated in set_fan_div(). |
| |
| Reported-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Axel Lin <axel.lin@ingics.com> |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/hwmon/adm1029.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| --- a/drivers/hwmon/adm1029.c |
| +++ b/drivers/hwmon/adm1029.c |
| @@ -232,6 +232,9 @@ static ssize_t set_fan_div(struct device |
| /* Update the value */ |
| reg = (reg & 0x3F) | (val << 6); |
| |
| + /* Update the cache */ |
| + data->fan_div[attr->index] = reg; |
| + |
| /* Write value */ |
| i2c_smbus_write_byte_data(client, |
| ADM1029_REG_FAN_DIV[attr->index], reg); |