| From 1b63bf617206ff35b93c57c67bbe067ac735a85a Mon Sep 17 00:00:00 2001 |
| From: Guenter Roeck <linux@roeck-us.net> |
| Date: Thu, 28 May 2015 09:08:09 -0700 |
| Subject: hwmon: (nct6775) Add missing sysfs attribute initialization |
| |
| From: Guenter Roeck <linux@roeck-us.net> |
| |
| commit 1b63bf617206ff35b93c57c67bbe067ac735a85a upstream. |
| |
| The following error message is seen when loading the nct6775 driver |
| with DEBUG_LOCK_ALLOC enabled. |
| |
| BUG: key ffff88040b2f0030 not in .data! |
| ------------[ cut here ]------------ |
| WARNING: CPU: 0 PID: 186 at kernel/locking/lockdep.c:2988 |
| lockdep_init_map+0x469/0x630() |
| DEBUG_LOCKS_WARN_ON(1) |
| |
| Caused by a missing call to sysfs_attr_init() when initializing |
| sysfs attributes. |
| |
| Reported-by: Alexey Orishko <alexey.orishko@gmail.com> |
| Reviewed-by: Jean Delvare <jdelvare@suse.de> |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/hwmon/nct6775.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/drivers/hwmon/nct6775.c |
| +++ b/drivers/hwmon/nct6775.c |
| @@ -986,6 +986,7 @@ nct6775_create_attr_group(struct device |
| (*t)->dev_attr.attr.name, tg->base + i); |
| if ((*t)->s2) { |
| a2 = &su->u.a2; |
| + sysfs_attr_init(&a2->dev_attr.attr); |
| a2->dev_attr.attr.name = su->name; |
| a2->nr = (*t)->u.s.nr + i; |
| a2->index = (*t)->u.s.index; |
| @@ -996,6 +997,7 @@ nct6775_create_attr_group(struct device |
| *attrs = &a2->dev_attr.attr; |
| } else { |
| a = &su->u.a1; |
| + sysfs_attr_init(&a->dev_attr.attr); |
| a->dev_attr.attr.name = su->name; |
| a->index = (*t)->u.index + i; |
| a->dev_attr.attr.mode = |