| From 58930cced012adb01bc78b3687049b17ef44d0a3 Mon Sep 17 00:00:00 2001 |
| From: Arnd Bergmann <arnd@arndb.de> |
| Date: Tue, 5 Sep 2017 09:33:32 +0200 |
| Subject: staging: rts5208: fix gcc-8 logic error warning |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| commit 58930cced012adb01bc78b3687049b17ef44d0a3 upstream. |
| |
| As gcc-8 points out, the bit mask check makes no sense here: |
| |
| drivers/staging/rts5208/sd.c: In function 'ext_sd_send_cmd_get_rsp': |
| drivers/staging/rts5208/sd.c:4130:25: error: bitwise comparison always evaluates to true [-Werror=tautological-compare] |
| |
| However, the code is even more bogus, as we have already |
| checked for the SD_RSP_TYPE_R0 case earlier in the function |
| and returned success. As seen in the mmc/sd driver core, |
| SD_RSP_TYPE_R0 means "no response" anyway, so checking for |
| a particular response would not help either. |
| |
| This just removes the nonsensical code to get rid of the |
| warning. |
| |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/staging/rts5208/sd.c | 3 --- |
| 1 file changed, 3 deletions(-) |
| |
| --- a/drivers/staging/rts5208/sd.c |
| +++ b/drivers/staging/rts5208/sd.c |
| @@ -3531,9 +3531,6 @@ RTY_SEND_CMD: |
| if ((ptr[3] & 0x1E) != 0x04) |
| TRACE_RET(chip, STATUS_FAIL); |
| |
| - } else if (rsp_type == SD_RSP_TYPE_R0) { |
| - if ((ptr[3] & 0x1E) != 0x03) |
| - TRACE_RET(chip, STATUS_FAIL); |
| } |
| } |
| } |
