| From foo@baz Mon Dec 18 15:03:25 CET 2017 |
| From: Jiang Yi <jiangyilism@gmail.com> |
| Date: Fri, 11 Aug 2017 11:29:44 +0800 |
| Subject: target/file: Do not return error for UNMAP if length is zero |
| |
| From: Jiang Yi <jiangyilism@gmail.com> |
| |
| |
| [ Upstream commit 594e25e73440863981032d76c9b1e33409ceff6e ] |
| |
| The function fd_execute_unmap() in target_core_file.c calles |
| |
| ret = file->f_op->fallocate(file, mode, pos, len); |
| |
| Some filesystems implement fallocate() to return error if |
| length is zero (e.g. btrfs) but according to SCSI Block |
| Commands spec UNMAP should return success for zero length. |
| |
| Signed-off-by: Jiang Yi <jiangyilism@gmail.com> |
| Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> |
| Signed-off-by: Sasha Levin <alexander.levin@verizon.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/target/target_core_file.c | 4 ++++ |
| 1 file changed, 4 insertions(+) |
| |
| --- a/drivers/target/target_core_file.c |
| +++ b/drivers/target/target_core_file.c |
| @@ -592,6 +592,10 @@ fd_do_unmap(struct se_cmd *cmd, void *pr |
| struct inode *inode = file->f_mapping->host; |
| int ret; |
| |
| + if (!nolb) { |
| + return 0; |
| + } |
| + |
| if (cmd->se_dev->dev_attrib.pi_prot_type) { |
| ret = fd_do_prot_unmap(cmd, lba, nolb); |
| if (ret) |
