| From ad774702f1705c04e5fa492b793d8d477a504fa6 Mon Sep 17 00:00:00 2001 |
| From: Krzysztof Kozlowski <k.kozlowski@samsung.com> |
| Date: Thu, 12 Mar 2015 08:43:59 +0100 |
| Subject: compal-laptop: Fix leaking hwmon device |
| |
| From: Krzysztof Kozlowski <k.kozlowski@samsung.com> |
| |
| commit ad774702f1705c04e5fa492b793d8d477a504fa6 upstream. |
| |
| The commit c2be45f09bb0 ("compal-laptop: Use |
| devm_hwmon_device_register_with_groups") wanted to change the |
| registering of hwmon device to resource-managed version. It mostly did |
| it except the main thing - it forgot to use devm-like function so the |
| hwmon device leaked after device removal or probe failure. |
| |
| Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> |
| Fixes: c2be45f09bb0 ("compal-laptop: Use devm_hwmon_device_register_with_groups") |
| Acked-by: Guenter Roeck <linux@roeck-us.net> |
| Acked-by: Darren Hart <dvhart@linux.intel.com> |
| Signed-off-by: Sebastian Reichel <sre@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/platform/x86/compal-laptop.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| --- a/drivers/platform/x86/compal-laptop.c |
| +++ b/drivers/platform/x86/compal-laptop.c |
| @@ -1026,9 +1026,9 @@ static int compal_probe(struct platform_ |
| if (err) |
| return err; |
| |
| - hwmon_dev = hwmon_device_register_with_groups(&pdev->dev, |
| - "compal", data, |
| - compal_hwmon_groups); |
| + hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev, |
| + "compal", data, |
| + compal_hwmon_groups); |
| if (IS_ERR(hwmon_dev)) { |
| err = PTR_ERR(hwmon_dev); |
| goto remove; |
