| From 13f6b191aaa11c7fd718d35a0c565f3c16bc1d99 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Thu, 16 Apr 2015 12:48:35 -0700 |
| Subject: memstick: mspro_block: add missing curly braces |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| commit 13f6b191aaa11c7fd718d35a0c565f3c16bc1d99 upstream. |
| |
| Using the indenting we can see the curly braces were obviously intended. |
| This is a static checker fix, but my guess is that we don't read enough |
| bytes, because we don't calculate "t_len" correctly. |
| |
| Fixes: f1d82698029b ('memstick: use fully asynchronous request processing') |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Cc: Alex Dubov <oakad@yahoo.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/memstick/core/mspro_block.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/memstick/core/mspro_block.c |
| +++ b/drivers/memstick/core/mspro_block.c |
| @@ -758,7 +758,7 @@ static int mspro_block_complete_req(stru |
| |
| if (error || (card->current_mrq.tpc == MSPRO_CMD_STOP)) { |
| if (msb->data_dir == READ) { |
| - for (cnt = 0; cnt < msb->current_seg; cnt++) |
| + for (cnt = 0; cnt < msb->current_seg; cnt++) { |
| t_len += msb->req_sg[cnt].length |
| / msb->page_size; |
| |
| @@ -766,6 +766,7 @@ static int mspro_block_complete_req(stru |
| t_len += msb->current_page - 1; |
| |
| t_len *= msb->page_size; |
| + } |
| } |
| } else |
| t_len = blk_rq_bytes(msb->block_req); |