| From c3b55e2ec9c76e7a0de2a0b1dc851fdc9440385b Mon Sep 17 00:00:00 2001 |
| From: Takashi Sakamoto <o-takashi@sakamocchi.jp> |
| Date: Mon, 17 Sep 2018 17:26:41 +0900 |
| Subject: ALSA: fireworks: fix memory leak of response buffer at error path |
| |
| From: Takashi Sakamoto <o-takashi@sakamocchi.jp> |
| |
| commit c3b55e2ec9c76e7a0de2a0b1dc851fdc9440385b upstream. |
| |
| After allocating memory object for response buffer, ALSA fireworks |
| driver has leak of the memory object at error path. |
| |
| This commit releases the object at the error path. |
| |
| Fixes: 7d3c1d5901aa('ALSA: fireworks: delayed registration of sound card') |
| Cc: <stable@vger.kernel.org> # v4.7+ |
| Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| sound/firewire/fireworks/fireworks.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/sound/firewire/fireworks/fireworks.c |
| +++ b/sound/firewire/fireworks/fireworks.c |
| @@ -301,6 +301,8 @@ error: |
| snd_efw_transaction_remove_instance(efw); |
| snd_efw_stream_destroy_duplex(efw); |
| snd_card_free(efw->card); |
| + kfree(efw->resp_buf); |
| + efw->resp_buf = NULL; |
| dev_info(&efw->unit->device, |
| "Sound card registration failed: %d\n", err); |
| } |