| From 906ca6353ac09696c1bf0892513c8edffff5e0a6 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Tue, 22 Oct 2019 13:23:24 +0300 |
| Subject: scsi: esas2r: unlock on error in esas2r_nvram_read_direct() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| commit 906ca6353ac09696c1bf0892513c8edffff5e0a6 upstream. |
| |
| This error path is missing an unlock. |
| |
| Fixes: 26780d9e12ed ("[SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver") |
| Link: https://lore.kernel.org/r/20191022102324.GA27540@mwanda |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/scsi/esas2r/esas2r_flash.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/scsi/esas2r/esas2r_flash.c |
| +++ b/drivers/scsi/esas2r/esas2r_flash.c |
| @@ -1197,6 +1197,7 @@ bool esas2r_nvram_read_direct(struct esa |
| if (!esas2r_read_flash_block(a, a->nvram, FLS_OFFSET_NVR, |
| sizeof(struct esas2r_sas_nvram))) { |
| esas2r_hdebug("NVRAM read failed, using defaults"); |
| + up(&a->nvram_semaphore); |
| return false; |
| } |
| |
