| From 66072c29328717072fd84aaff3e070e3f008ba77 Mon Sep 17 00:00:00 2001 |
| From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> |
| Date: Fri, 18 May 2018 16:09:16 -0700 |
| Subject: hfsplus: stop workqueue when fill_super() failed |
| |
| From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> |
| |
| commit 66072c29328717072fd84aaff3e070e3f008ba77 upstream. |
| |
| syzbot is reporting ODEBUG messages at hfsplus_fill_super() [1]. This |
| is because hfsplus_fill_super() forgot to call cancel_delayed_work_sync(). |
| |
| As far as I can see, it is hfsplus_mark_mdb_dirty() from |
| hfsplus_new_inode() in hfsplus_fill_super() that calls |
| queue_delayed_work(). Therefore, I assume that hfsplus_new_inode() does |
| not fail if queue_delayed_work() was called, and the out_put_hidden_dir |
| label is the appropriate location to call cancel_delayed_work_sync(). |
| |
| [1] https://syzkaller.appspot.com/bug?id=a66f45e96fdbeb76b796bf46eb25ea878c42a6c9 |
| |
| Link: http://lkml.kernel.org/r/964a8b27-cd69-357c-fe78-76b066056201@I-love.SAKURA.ne.jp |
| Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> |
| Reported-by: syzbot <syzbot+4f2e5f086147d543ab03@syzkaller.appspotmail.com> |
| Cc: Al Viro <viro@zeniv.linux.org.uk> |
| Cc: David Howells <dhowells@redhat.com> |
| Cc: Ernesto A. Fernandez <ernesto.mnd.fernandez@gmail.com> |
| Cc: Vyacheslav Dubeyko <slava@dubeyko.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/hfsplus/super.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/fs/hfsplus/super.c |
| +++ b/fs/hfsplus/super.c |
| @@ -588,6 +588,7 @@ static int hfsplus_fill_super(struct sup |
| return 0; |
| |
| out_put_hidden_dir: |
| + cancel_delayed_work_sync(&sbi->sync_work); |
| iput(sbi->hidden_dir); |
| out_put_root: |
| dput(sb->s_root); |
