| From foo@baz Sun Nov 19 11:32:28 CET 2017 |
| From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
| Date: Wed, 6 Jul 2016 19:33:05 +0200 |
| Subject: backlight: lcd: Fix race condition during register |
| |
| From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
| |
| |
| [ Upstream commit cc21942bce652d1a92dae85b785378256e1df1f7 ] |
| |
| Once device_register is called for a device its attributes might be |
| accessed. As the callbacks of a lcd device's attributes make use of the |
| lcd_ops, the respective member must be setup before calling |
| device_register. |
| |
| Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
| Signed-off-by: Lee Jones <lee.jones@linaro.org> |
| Signed-off-by: Sasha Levin <alexander.levin@verizon.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/video/backlight/lcd.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/video/backlight/lcd.c |
| +++ b/drivers/video/backlight/lcd.c |
| @@ -226,6 +226,8 @@ struct lcd_device *lcd_device_register(c |
| dev_set_name(&new_ld->dev, "%s", name); |
| dev_set_drvdata(&new_ld->dev, devdata); |
| |
| + new_ld->ops = ops; |
| + |
| rc = device_register(&new_ld->dev); |
| if (rc) { |
| put_device(&new_ld->dev); |
| @@ -238,8 +240,6 @@ struct lcd_device *lcd_device_register(c |
| return ERR_PTR(rc); |
| } |
| |
| - new_ld->ops = ops; |
| - |
| return new_ld; |
| } |
| EXPORT_SYMBOL(lcd_device_register); |
