| From e36215d87f301f9567c8c99fd34e6c3521a94ddf Mon Sep 17 00:00:00 2001 |
| From: Matthias Kaehlcke <mka@chromium.org> |
| Date: Mon, 17 Apr 2017 11:05:03 -0700 |
| Subject: dm ioctl: remove double parentheses |
| |
| From: Matthias Kaehlcke <mka@chromium.org> |
| |
| commit e36215d87f301f9567c8c99fd34e6c3521a94ddf upstream. |
| |
| The extra pair of parantheses is not needed and causes clang to generate |
| warnings about the DM_DEV_CREATE_CMD comparison in validate_params(). |
| |
| Also remove another double parentheses that doesn't cause a warning. |
| |
| Signed-off-by: Matthias Kaehlcke <mka@chromium.org> |
| Signed-off-by: Mike Snitzer <snitzer@redhat.com> |
| Cc: Nathan Chancellor <natechancellor@gmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/md/dm-ioctl.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/md/dm-ioctl.c |
| +++ b/drivers/md/dm-ioctl.c |
| @@ -1777,12 +1777,12 @@ static int validate_params(uint cmd, str |
| cmd == DM_LIST_VERSIONS_CMD) |
| return 0; |
| |
| - if ((cmd == DM_DEV_CREATE_CMD)) { |
| + if (cmd == DM_DEV_CREATE_CMD) { |
| if (!*param->name) { |
| DMWARN("name not supplied when creating device"); |
| return -EINVAL; |
| } |
| - } else if ((*param->uuid && *param->name)) { |
| + } else if (*param->uuid && *param->name) { |
| DMWARN("only supply one of name or uuid, cmd(%u)", cmd); |
| return -EINVAL; |
| } |
