| From 8e8ac37501c46bf12e8e818c29aa9fb6d972d87e Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 6 Jun 2020 17:50:16 +0800 |
| Subject: irqchip/ti-sci-inta: Fix return value about devm_ioremap_resource() |
| |
| From: Tiezhu Yang <yangtiezhu@loongson.cn> |
| |
| [ Upstream commit 4b127a14cb1385dd355c7673d975258d5d668922 ] |
| |
| When call function devm_ioremap_resource(), we should use IS_ERR() |
| to check the return value and return PTR_ERR() if failed. |
| |
| Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver") |
| Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> |
| Signed-off-by: Marc Zyngier <maz@kernel.org> |
| Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> |
| Link: https://lore.kernel.org/r/1591437017-5295-2-git-send-email-yangtiezhu@loongson.cn |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/irqchip/irq-ti-sci-inta.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c |
| index fa7488863bd0a..0a35499c46728 100644 |
| --- a/drivers/irqchip/irq-ti-sci-inta.c |
| +++ b/drivers/irqchip/irq-ti-sci-inta.c |
| @@ -571,7 +571,7 @@ static int ti_sci_inta_irq_domain_probe(struct platform_device *pdev) |
| res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| inta->base = devm_ioremap_resource(dev, res); |
| if (IS_ERR(inta->base)) |
| - return -ENODEV; |
| + return PTR_ERR(inta->base); |
| |
| domain = irq_domain_add_linear(dev_of_node(dev), |
| ti_sci_get_num_resources(inta->vint), |
| -- |
| 2.25.1 |
| |
