| { |
| "containers": { |
| "cna": { |
| "providerMetadata": { |
| "orgId": "f4215fc3-5b6b-47ff-a258-f7189bd81038" |
| }, |
| "descriptions": [ |
| { |
| "lang": "en", |
| "value": "In the Linux kernel, the following vulnerability has been resolved:\n\nnet/sched: flower: Fix chain template offload\n\nWhen a qdisc is deleted from a net device the stack instructs the\nunderlying driver to remove its flow offload callback from the\nassociated filter block using the 'FLOW_BLOCK_UNBIND' command. The stack\nthen continues to replay the removal of the filters in the block for\nthis driver by iterating over the chains in the block and invoking the\n'reoffload' operation of the classifier being used. In turn, the\nclassifier in its 'reoffload' operation prepares and emits a\n'FLOW_CLS_DESTROY' command for each filter.\n\nHowever, the stack does not do the same for chain templates and the\nunderlying driver never receives a 'FLOW_CLS_TMPLT_DESTROY' command when\na qdisc is deleted. This results in a memory leak [1] which can be\nreproduced using [2].\n\nFix by introducing a 'tmplt_reoffload' operation and have the stack\ninvoke it with the appropriate arguments as part of the replay.\nImplement the operation in the sole classifier that supports chain\ntemplates (flower) by emitting the 'FLOW_CLS_TMPLT_{CREATE,DESTROY}'\ncommand based on whether a flow offload callback is being bound to a\nfilter block or being unbound from one.\n\nAs far as I can tell, the issue happens since cited commit which\nreordered tcf_block_offload_unbind() before tcf_block_flush_all_chains()\nin __tcf_block_put(). The order cannot be reversed as the filter block\nis expected to be freed after flushing all the chains.\n\n[1]\nunreferenced object 0xffff888107e28800 (size 2048):\n comm \"tc\", pid 1079, jiffies 4294958525 (age 3074.287s)\n hex dump (first 32 bytes):\n b1 a6 7c 11 81 88 ff ff e0 5b b3 10 81 88 ff ff ..|......[......\n 01 00 00 00 00 00 00 00 e0 aa b0 84 ff ff ff ff ................\n backtrace:\n [<ffffffff81c06a68>] __kmem_cache_alloc_node+0x1e8/0x320\n [<ffffffff81ab374e>] __kmalloc+0x4e/0x90\n [<ffffffff832aec6d>] mlxsw_sp_acl_ruleset_get+0x34d/0x7a0\n [<ffffffff832bc195>] mlxsw_sp_flower_tmplt_create+0x145/0x180\n [<ffffffff832b2e1a>] mlxsw_sp_flow_block_cb+0x1ea/0x280\n [<ffffffff83a10613>] tc_setup_cb_call+0x183/0x340\n [<ffffffff83a9f85a>] fl_tmplt_create+0x3da/0x4c0\n [<ffffffff83a22435>] tc_ctl_chain+0xa15/0x1170\n [<ffffffff838a863c>] rtnetlink_rcv_msg+0x3cc/0xed0\n [<ffffffff83ac87f0>] netlink_rcv_skb+0x170/0x440\n [<ffffffff83ac6270>] netlink_unicast+0x540/0x820\n [<ffffffff83ac6e28>] netlink_sendmsg+0x8d8/0xda0\n [<ffffffff83793def>] ____sys_sendmsg+0x30f/0xa80\n [<ffffffff8379d29a>] ___sys_sendmsg+0x13a/0x1e0\n [<ffffffff8379d50c>] __sys_sendmsg+0x11c/0x1f0\n [<ffffffff843b9ce0>] do_syscall_64+0x40/0xe0\nunreferenced object 0xffff88816d2c0400 (size 1024):\n comm \"tc\", pid 1079, jiffies 4294958525 (age 3074.287s)\n hex dump (first 32 bytes):\n 40 00 00 00 00 00 00 00 57 f6 38 be 00 00 00 00 @.......W.8.....\n 10 04 2c 6d 81 88 ff ff 10 04 2c 6d 81 88 ff ff ..,m......,m....\n backtrace:\n [<ffffffff81c06a68>] __kmem_cache_alloc_node+0x1e8/0x320\n [<ffffffff81ab36c1>] __kmalloc_node+0x51/0x90\n [<ffffffff81a8ed96>] kvmalloc_node+0xa6/0x1f0\n [<ffffffff82827d03>] bucket_table_alloc.isra.0+0x83/0x460\n [<ffffffff82828d2b>] rhashtable_init+0x43b/0x7c0\n [<ffffffff832aed48>] mlxsw_sp_acl_ruleset_get+0x428/0x7a0\n [<ffffffff832bc195>] mlxsw_sp_flower_tmplt_create+0x145/0x180\n [<ffffffff832b2e1a>] mlxsw_sp_flow_block_cb+0x1ea/0x280\n [<ffffffff83a10613>] tc_setup_cb_call+0x183/0x340\n [<ffffffff83a9f85a>] fl_tmplt_create+0x3da/0x4c0\n [<ffffffff83a22435>] tc_ctl_chain+0xa15/0x1170\n [<ffffffff838a863c>] rtnetlink_rcv_msg+0x3cc/0xed0\n [<ffffffff83ac87f0>] netlink_rcv_skb+0x170/0x440\n [<ffffffff83ac6270>] netlink_unicast+0x540/0x820\n [<ffffffff83ac6e28>] netlink_sendmsg+0x8d8/0xda0\n [<ffffffff83793def>] ____sys_sendmsg+0x30f/0xa80\n\n[2]\n # tc qdisc add dev swp1 clsact\n # tc chain add dev swp1 ingress proto ip chain 1 flower dst_ip 0.0.0.0/32\n # tc qdisc del dev\n---truncated---" |
| } |
| ], |
| "affected": [ |
| { |
| "product": "Linux", |
| "vendor": "Linux", |
| "defaultStatus": "unaffected", |
| "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git", |
| "programFiles": [ |
| "include/net/sch_generic.h", |
| "net/sched/cls_api.c", |
| "net/sched/cls_flower.c" |
| ], |
| "versions": [ |
| { |
| "version": "bbf73830cd48cff1599811d4f69c7cfd49c7b869", |
| "lessThan": "9ed46144cff3598a5cf79955630e795ff9af5b97", |
| "status": "affected", |
| "versionType": "git" |
| }, |
| { |
| "version": "bbf73830cd48cff1599811d4f69c7cfd49c7b869", |
| "lessThan": "c04709b2cc99ae31c346f79f0211752d7b74df01", |
| "status": "affected", |
| "versionType": "git" |
| }, |
| { |
| "version": "bbf73830cd48cff1599811d4f69c7cfd49c7b869", |
| "lessThan": "32f2a0afa95fae0d1ceec2ff06e0e816939964b8", |
| "status": "affected", |
| "versionType": "git" |
| } |
| ] |
| }, |
| { |
| "product": "Linux", |
| "vendor": "Linux", |
| "defaultStatus": "affected", |
| "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git", |
| "programFiles": [ |
| "include/net/sch_generic.h", |
| "net/sched/cls_api.c", |
| "net/sched/cls_flower.c" |
| ], |
| "versions": [ |
| { |
| "version": "5.1", |
| "status": "affected" |
| }, |
| { |
| "version": "0", |
| "lessThan": "5.1", |
| "status": "unaffected", |
| "versionType": "semver" |
| }, |
| { |
| "version": "6.6.15", |
| "lessThanOrEqual": "6.6.*", |
| "status": "unaffected", |
| "versionType": "semver" |
| }, |
| { |
| "version": "6.7.3", |
| "lessThanOrEqual": "6.7.*", |
| "status": "unaffected", |
| "versionType": "semver" |
| }, |
| { |
| "version": "6.8", |
| "lessThanOrEqual": "*", |
| "status": "unaffected", |
| "versionType": "original_commit_for_fix" |
| } |
| ] |
| } |
| ], |
| "cpeApplicability": [ |
| { |
| "nodes": [ |
| { |
| "operator": "OR", |
| "negate": false, |
| "cpeMatch": [ |
| { |
| "vulnerable": true, |
| "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*", |
| "versionStartIncluding": "5.1", |
| "versionEndExcluding": "6.6.15" |
| }, |
| { |
| "vulnerable": true, |
| "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*", |
| "versionStartIncluding": "5.1", |
| "versionEndExcluding": "6.7.3" |
| }, |
| { |
| "vulnerable": true, |
| "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*", |
| "versionStartIncluding": "5.1", |
| "versionEndExcluding": "6.8" |
| } |
| ] |
| } |
| ] |
| } |
| ], |
| "references": [ |
| { |
| "url": "https://git.kernel.org/stable/c/9ed46144cff3598a5cf79955630e795ff9af5b97" |
| }, |
| { |
| "url": "https://git.kernel.org/stable/c/c04709b2cc99ae31c346f79f0211752d7b74df01" |
| }, |
| { |
| "url": "https://git.kernel.org/stable/c/32f2a0afa95fae0d1ceec2ff06e0e816939964b8" |
| } |
| ], |
| "title": "net/sched: flower: Fix chain template offload", |
| "x_generator": { |
| "engine": "bippy-1.2.0" |
| } |
| } |
| }, |
| "cveMetadata": { |
| "assignerOrgId": "f4215fc3-5b6b-47ff-a258-f7189bd81038", |
| "cveID": "CVE-2024-26669", |
| "requesterUserId": "gregkh@kernel.org", |
| "serial": "1", |
| "state": "PUBLISHED" |
| }, |
| "dataType": "CVE_RECORD", |
| "dataVersion": "5.0" |
| } |
