| From bippy-5f407fcff5a0 Mon Sep 17 00:00:00 2001 |
| From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| To: <linux-cve-announce@vger.kernel.org> |
| Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org> |
| Subject: CVE-2024-42110: net: ntb_netdev: Move ntb_netdev_rx_handler() to call netif_rx() from __netif_rx() |
| |
| Description |
| =========== |
| |
| In the Linux kernel, the following vulnerability has been resolved: |
| |
| net: ntb_netdev: Move ntb_netdev_rx_handler() to call netif_rx() from __netif_rx() |
| |
| The following is emitted when using idxd (DSA) dmanegine as the data |
| mover for ntb_transport that ntb_netdev uses. |
| |
| [74412.546922] BUG: using smp_processor_id() in preemptible [00000000] code: irq/52-idxd-por/14526 |
| [74412.556784] caller is netif_rx_internal+0x42/0x130 |
| [74412.562282] CPU: 6 PID: 14526 Comm: irq/52-idxd-por Not tainted 6.9.5 #5 |
| [74412.569870] Hardware name: Intel Corporation ArcherCity/ArcherCity, BIOS EGSDCRB1.E9I.1752.P05.2402080856 02/08/2024 |
| [74412.581699] Call Trace: |
| [74412.584514] <TASK> |
| [74412.586933] dump_stack_lvl+0x55/0x70 |
| [74412.591129] check_preemption_disabled+0xc8/0xf0 |
| [74412.596374] netif_rx_internal+0x42/0x130 |
| [74412.600957] __netif_rx+0x20/0xd0 |
| [74412.604743] ntb_netdev_rx_handler+0x66/0x150 [ntb_netdev] |
| [74412.610985] ntb_complete_rxc+0xed/0x140 [ntb_transport] |
| [74412.617010] ntb_rx_copy_callback+0x53/0x80 [ntb_transport] |
| [74412.623332] idxd_dma_complete_txd+0xe3/0x160 [idxd] |
| [74412.628963] idxd_wq_thread+0x1a6/0x2b0 [idxd] |
| [74412.634046] irq_thread_fn+0x21/0x60 |
| [74412.638134] ? irq_thread+0xa8/0x290 |
| [74412.642218] irq_thread+0x1a0/0x290 |
| [74412.646212] ? __pfx_irq_thread_fn+0x10/0x10 |
| [74412.651071] ? __pfx_irq_thread_dtor+0x10/0x10 |
| [74412.656117] ? __pfx_irq_thread+0x10/0x10 |
| [74412.660686] kthread+0x100/0x130 |
| [74412.664384] ? __pfx_kthread+0x10/0x10 |
| [74412.668639] ret_from_fork+0x31/0x50 |
| [74412.672716] ? __pfx_kthread+0x10/0x10 |
| [74412.676978] ret_from_fork_asm+0x1a/0x30 |
| [74412.681457] </TASK> |
| |
| The cause is due to the idxd driver interrupt completion handler uses |
| threaded interrupt and the threaded handler is not hard or soft interrupt |
| context. However __netif_rx() can only be called from interrupt context. |
| Change the call to netif_rx() in order to allow completion via normal |
| context for dmaengine drivers that utilize threaded irq handling. |
| |
| While the following commit changed from netif_rx() to __netif_rx(), |
| baebdf48c360 ("net: dev: Makes sure netif_rx() can be invoked in any context."), |
| the change should've been a noop instead. However, the code precedes this |
| fix should've been using netif_rx_ni() or netif_rx_any_context(). |
| |
| The Linux kernel CVE team has assigned CVE-2024-42110 to this issue. |
| |
| |
| Affected and fixed versions |
| =========================== |
| |
| Issue introduced in 3.9 with commit 548c237c0a9972df5d1afaca38aa733ee577128d and fixed in 6.1.98 with commit 4b3b6c7efee69f077b86ef7f088fb96768e46e1f |
| Issue introduced in 3.9 with commit 548c237c0a9972df5d1afaca38aa733ee577128d and fixed in 6.6.39 with commit e3af5b14e7632bf12058533d69055393e2d126c9 |
| Issue introduced in 3.9 with commit 548c237c0a9972df5d1afaca38aa733ee577128d and fixed in 6.9.9 with commit 858ae09f03677a4ab907a15516893bc2cc79d4c3 |
| Issue introduced in 3.9 with commit 548c237c0a9972df5d1afaca38aa733ee577128d and fixed in 6.10 with commit e15a5d821e5192a3769d846079bc9aa380139baf |
| |
| Please see https://www.kernel.org for a full list of currently supported |
| kernel versions by the kernel community. |
| |
| Unaffected versions might change over time as fixes are backported to |
| older supported kernel versions. The official CVE entry at |
| https://cve.org/CVERecord/?id=CVE-2024-42110 |
| will be updated if fixes are backported, please check that for the most |
| up to date information about this issue. |
| |
| |
| Affected files |
| ============== |
| |
| The file(s) affected by this issue are: |
| drivers/net/ntb_netdev.c |
| |
| |
| Mitigation |
| ========== |
| |
| The Linux kernel CVE team recommends that you update to the latest |
| stable kernel version for this, and many other bugfixes. Individual |
| changes are never tested alone, but rather are part of a larger kernel |
| release. Cherry-picking individual commits is not recommended or |
| supported by the Linux kernel community at all. If however, updating to |
| the latest release is impossible, the individual changes to resolve this |
| issue can be found at these commits: |
| https://git.kernel.org/stable/c/4b3b6c7efee69f077b86ef7f088fb96768e46e1f |
| https://git.kernel.org/stable/c/e3af5b14e7632bf12058533d69055393e2d126c9 |
| https://git.kernel.org/stable/c/858ae09f03677a4ab907a15516893bc2cc79d4c3 |
| https://git.kernel.org/stable/c/e15a5d821e5192a3769d846079bc9aa380139baf |
