| From bippy-5f407fcff5a0 Mon Sep 17 00:00:00 2001 |
| From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| To: <linux-cve-announce@vger.kernel.org> |
| Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org> |
| Subject: CVE-2024-50147: net/mlx5: Fix command bitmask initialization |
| |
| Description |
| =========== |
| |
| In the Linux kernel, the following vulnerability has been resolved: |
| |
| net/mlx5: Fix command bitmask initialization |
| |
| Command bitmask have a dedicated bit for MANAGE_PAGES command, this bit |
| isn't Initialize during command bitmask Initialization, only during |
| MANAGE_PAGES. |
| |
| In addition, mlx5_cmd_trigger_completions() is trying to trigger |
| completion for MANAGE_PAGES command as well. |
| |
| Hence, in case health error occurred before any MANAGE_PAGES command |
| have been invoke (for example, during mlx5_enable_hca()), |
| mlx5_cmd_trigger_completions() will try to trigger completion for |
| MANAGE_PAGES command, which will result in null-ptr-deref error.[1] |
| |
| Fix it by Initialize command bitmask correctly. |
| |
| While at it, re-write the code for better understanding. |
| |
| [1] |
| BUG: KASAN: null-ptr-deref in mlx5_cmd_trigger_completions+0x1db/0x600 [mlx5_core] |
| Write of size 4 at addr 0000000000000214 by task kworker/u96:2/12078 |
| CPU: 10 PID: 12078 Comm: kworker/u96:2 Not tainted 6.9.0-rc2_for_upstream_debug_2024_04_07_19_01 #1 |
| Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014 |
| Workqueue: mlx5_health0000:08:00.0 mlx5_fw_fatal_reporter_err_work [mlx5_core] |
| Call Trace: |
| <TASK> |
| dump_stack_lvl+0x7e/0xc0 |
| kasan_report+0xb9/0xf0 |
| kasan_check_range+0xec/0x190 |
| mlx5_cmd_trigger_completions+0x1db/0x600 [mlx5_core] |
| mlx5_cmd_flush+0x94/0x240 [mlx5_core] |
| enter_error_state+0x6c/0xd0 [mlx5_core] |
| mlx5_fw_fatal_reporter_err_work+0xf3/0x480 [mlx5_core] |
| process_one_work+0x787/0x1490 |
| ? lockdep_hardirqs_on_prepare+0x400/0x400 |
| ? pwq_dec_nr_in_flight+0xda0/0xda0 |
| ? assign_work+0x168/0x240 |
| worker_thread+0x586/0xd30 |
| ? rescuer_thread+0xae0/0xae0 |
| kthread+0x2df/0x3b0 |
| ? kthread_complete_and_exit+0x20/0x20 |
| ret_from_fork+0x2d/0x70 |
| ? kthread_complete_and_exit+0x20/0x20 |
| ret_from_fork_asm+0x11/0x20 |
| </TASK> |
| |
| The Linux kernel CVE team has assigned CVE-2024-50147 to this issue. |
| |
| |
| Affected and fixed versions |
| =========================== |
| |
| Issue introduced in 6.1 with commit 9b98d395b85dd042fe83fb696b1ac02e6c93a520 and fixed in 6.1.115 with commit d1606090bb294cecb7de3c4ed177f5aa0abd4c4e |
| Issue introduced in 6.1 with commit 9b98d395b85dd042fe83fb696b1ac02e6c93a520 and fixed in 6.6.59 with commit d88564c79d1cedaf2655f12261eca0d2796bde4e |
| Issue introduced in 6.1 with commit 9b98d395b85dd042fe83fb696b1ac02e6c93a520 and fixed in 6.11.6 with commit 2feac1e562be0efc621a6722644a90f355d53473 |
| Issue introduced in 6.1 with commit 9b98d395b85dd042fe83fb696b1ac02e6c93a520 and fixed in 6.12 with commit d62b14045c6511a7b2d4948d1a83a4e592deeb05 |
| |
| Please see https://www.kernel.org for a full list of currently supported |
| kernel versions by the kernel community. |
| |
| Unaffected versions might change over time as fixes are backported to |
| older supported kernel versions. The official CVE entry at |
| https://cve.org/CVERecord/?id=CVE-2024-50147 |
| will be updated if fixes are backported, please check that for the most |
| up to date information about this issue. |
| |
| |
| Affected files |
| ============== |
| |
| The file(s) affected by this issue are: |
| drivers/net/ethernet/mellanox/mlx5/core/cmd.c |
| |
| |
| Mitigation |
| ========== |
| |
| The Linux kernel CVE team recommends that you update to the latest |
| stable kernel version for this, and many other bugfixes. Individual |
| changes are never tested alone, but rather are part of a larger kernel |
| release. Cherry-picking individual commits is not recommended or |
| supported by the Linux kernel community at all. If however, updating to |
| the latest release is impossible, the individual changes to resolve this |
| issue can be found at these commits: |
| https://git.kernel.org/stable/c/d1606090bb294cecb7de3c4ed177f5aa0abd4c4e |
| https://git.kernel.org/stable/c/d88564c79d1cedaf2655f12261eca0d2796bde4e |
| https://git.kernel.org/stable/c/2feac1e562be0efc621a6722644a90f355d53473 |
| https://git.kernel.org/stable/c/d62b14045c6511a7b2d4948d1a83a4e592deeb05 |
