cve/published/2024/CVE-2024-50276.mbox

From bippy-5f407fcff5a0 Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: <linux-cve-announce@vger.kernel.org>
Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: CVE-2024-50276: net: vertexcom: mse102x: Fix possible double free of TX skb

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

net: vertexcom: mse102x: Fix possible double free of TX skb

The scope of the TX skb is wider than just mse102x_tx_frame_spi(),
so in case the TX skb room needs to be expanded, we should free the
the temporary skb instead of the original skb. Otherwise the original
TX skb pointer would be freed again in mse102x_tx_work(), which leads
to crashes:

  Internal error: Oops: 0000000096000004 [#2] PREEMPT SMP
  CPU: 0 PID: 712 Comm: kworker/0:1 Tainted: G      D            6.6.23
  Hardware name: chargebyte Charge SOM DC-ONE (DT)
  Workqueue: events mse102x_tx_work [mse102x]
  pstate: 20400009 (nzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
  pc : skb_release_data+0xb8/0x1d8
  lr : skb_release_data+0x1ac/0x1d8
  sp : ffff8000819a3cc0
  x29: ffff8000819a3cc0 x28: ffff0000046daa60 x27: ffff0000057f2dc0
  x26: ffff000005386c00 x25: 0000000000000002 x24: 00000000ffffffff
  x23: 0000000000000000 x22: 0000000000000001 x21: ffff0000057f2e50
  x20: 0000000000000006 x19: 0000000000000000 x18: ffff00003fdacfcc
  x17: e69ad452d0c49def x16: 84a005feff870102 x15: 0000000000000000
  x14: 000000000000024a x13: 0000000000000002 x12: 0000000000000000
  x11: 0000000000000400 x10: 0000000000000930 x9 : ffff00003fd913e8
  x8 : fffffc00001bc008
  x7 : 0000000000000000 x6 : 0000000000000008
  x5 : ffff00003fd91340 x4 : 0000000000000000 x3 : 0000000000000009
  x2 : 00000000fffffffe x1 : 0000000000000000 x0 : 0000000000000000
  Call trace:
   skb_release_data+0xb8/0x1d8
   kfree_skb_reason+0x48/0xb0
   mse102x_tx_work+0x164/0x35c [mse102x]
   process_one_work+0x138/0x260
   worker_thread+0x32c/0x438
   kthread+0x118/0x11c
   ret_from_fork+0x10/0x20
  Code: aa1303e0 97fffab6 72001c1f 54000141 (f9400660)

The Linux kernel CVE team has assigned CVE-2024-50276 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 5.17 with commit 2f207cbf0dd44278af2aa3ff0fc95b0f97cc4e4c and fixed in 6.1.117 with commit 2cf0e77f5a0aa1ff336aa71743eda55c73902187
	Issue introduced in 5.17 with commit 2f207cbf0dd44278af2aa3ff0fc95b0f97cc4e4c and fixed in 6.6.61 with commit 1325e838089da25217f4b403318a270fcdf88f34
	Issue introduced in 5.17 with commit 2f207cbf0dd44278af2aa3ff0fc95b0f97cc4e4c and fixed in 6.11.8 with commit 91c9daa21f3ff8668f9e1d6c860024ce7ad64137
	Issue introduced in 5.17 with commit 2f207cbf0dd44278af2aa3ff0fc95b0f97cc4e4c and fixed in 6.12 with commit 1f26339b2ed63d1e8e18a18674fb73a392f3660e

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2024-50276
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/net/ethernet/vertexcom/mse102x.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/2cf0e77f5a0aa1ff336aa71743eda55c73902187
	https://git.kernel.org/stable/c/1325e838089da25217f4b403318a270fcdf88f34
	https://git.kernel.org/stable/c/91c9daa21f3ff8668f9e1d6c860024ce7ad64137
	https://git.kernel.org/stable/c/1f26339b2ed63d1e8e18a18674fb73a392f3660e