cve/published/2025/CVE-2025-22109.mbox - pub/scm/linux/security/vulns - Git at Google

 From bippy-1.2.0 Mon Sep 17 00:00:00 2001
 From: Greg Kroah-Hartman <gregkh@kernel.org>
 To: <linux-cve-announce@vger.kernel.org>
 Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org>
 Subject: CVE-2025-22109: ax25: Remove broken autobind

 Description
 ===========

 In the Linux kernel, the following vulnerability has been resolved:

 ax25: Remove broken autobind

 Binding AX25 socket by using the autobind feature leads to memory leaks
 in ax25_connect() and also refcount leaks in ax25_release(). Memory
 leak was detected with kmemleak:

 ================================================================
 unreferenced object 0xffff8880253cd680 (size 96):
 backtrace:
 __kmalloc_node_track_caller_noprof (./include/linux/kmemleak.h:43)
 kmemdup_noprof (mm/util.c:136)
 ax25_rt_autobind (net/ax25/ax25_route.c:428)
 ax25_connect (net/ax25/af_ax25.c:1282)
 __sys_connect_file (net/socket.c:2045)
 __sys_connect (net/socket.c:2064)
 __x64_sys_connect (net/socket.c:2067)
 do_syscall_64 (arch/x86/entry/common.c:52 arch/x86/entry/common.c:83)
 entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:130)
 ================================================================

 When socket is bound, refcounts must be incremented the way it is done
 in ax25_bind() and ax25_setsockopt() (SO_BINDTODEVICE). In case of
 autobind, the refcounts are not incremented.

 This bug leads to the following issue reported by Syzkaller:

 ================================================================
 ax25_connect(): syz-executor318 uses autobind, please contact jreuter@yaina.de
 ------------[ cut here ]------------
 refcount_t: decrement hit 0; leaking memory.
 WARNING: CPU: 0 PID: 5317 at lib/refcount.c:31 refcount_warn_saturate+0xfa/0x1d0 lib/refcount.c:31
 Modules linked in:
 CPU: 0 UID: 0 PID: 5317 Comm: syz-executor318 Not tainted 6.14.0-rc4-syzkaller-00278-gece144f151ac #0
 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
 RIP: 0010:refcount_warn_saturate+0xfa/0x1d0 lib/refcount.c:31
 ...
 Call Trace:
  <TASK>
  __refcount_dec include/linux/refcount.h:336 [inline]
  refcount_dec include/linux/refcount.h:351 [inline]
  ref_tracker_free+0x6af/0x7e0 lib/ref_tracker.c:236
  netdev_tracker_free include/linux/netdevice.h:4302 [inline]
  netdev_put include/linux/netdevice.h:4319 [inline]
  ax25_release+0x368/0x960 net/ax25/af_ax25.c:1080
  __sock_release net/socket.c:647 [inline]
  sock_close+0xbc/0x240 net/socket.c:1398
  __fput+0x3e9/0x9f0 fs/file_table.c:464
  __do_sys_close fs/open.c:1580 [inline]
  __se_sys_close fs/open.c:1565 [inline]
  __x64_sys_close+0x7f/0x110 fs/open.c:1565
  do_syscall_x64 arch/x86/entry/common.c:52 [inline]
  do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
  entry_SYSCALL_64_after_hwframe+0x77/0x7f
  ...
  </TASK>
 ================================================================

 Considering the issues above and the comments left in the code that say:
 "check if we can remove this feature. It is broken."; "autobinding in this
 may or may not work"; - it is better to completely remove this feature than
 to fix it because it is broken and leads to various kinds of memory bugs.

 Now calling connect() without first binding socket will result in an
 error (-EINVAL). Userspace software that relies on the autobind feature
 might get broken. However, this feature does not seem widely used with
 this specific driver as it was not reliable at any point of time, and it
 is already broken anyway. E.g. ax25-tools and ax25-apps packages for
 popular distributions do not use the autobind feature for AF_AX25.

 Found by Linux Verification Center (linuxtesting.org) with Syzkaller.

 The Linux kernel CVE team has assigned CVE-2025-22109 to this issue.


 Affected and fixed versions
 ===========================

 	Issue introduced in 2.6.12 with commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 and fixed in 6.14.2 with commit 61203fdd3e35519db9a98b6ff8983c620ffc4696
 	Issue introduced in 2.6.12 with commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 and fixed in 6.15 with commit 2f6efbabceb6b2914ee9bafb86d9a51feae9cce8

 Please see https://www.kernel.org for a full list of currently supported
 kernel versions by the kernel community.

 Unaffected versions might change over time as fixes are backported to
 older supported kernel versions.  The official CVE entry at
 	https://cve.org/CVERecord/?id=CVE-2025-22109
 will be updated if fixes are backported, please check that for the most
 up to date information about this issue.


 Affected files
 ==============

 The file(s) affected by this issue are:
 	include/net/ax25.h
 	net/ax25/af_ax25.c
 	net/ax25/ax25_route.c


 Mitigation
 ==========

 The Linux kernel CVE team recommends that you update to the latest
 stable kernel version for this, and many other bugfixes.  Individual
 changes are never tested alone, but rather are part of a larger kernel
 release.  Cherry-picking individual commits is not recommended or
 supported by the Linux kernel community at all.  If however, updating to
 the latest release is impossible, the individual changes to resolve this
 issue can be found at these commits:
 	https://git.kernel.org/stable/c/61203fdd3e35519db9a98b6ff8983c620ffc4696
 	https://git.kernel.org/stable/c/2f6efbabceb6b2914ee9bafb86d9a51feae9cce8
	From bippy-1.2.0 Mon Sep 17 00:00:00 2001
	From: Greg Kroah-Hartman <gregkh@kernel.org>
	To: <linux-cve-announce@vger.kernel.org>
	Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org>
	Subject: CVE-2025-22109: ax25: Remove broken autobind

	Description
	===========

	In the Linux kernel, the following vulnerability has been resolved:

	ax25: Remove broken autobind

	Binding AX25 socket by using the autobind feature leads to memory leaks
	in ax25_connect() and also refcount leaks in ax25_release(). Memory
	leak was detected with kmemleak:

	================================================================
	unreferenced object 0xffff8880253cd680 (size 96):
	backtrace:
	__kmalloc_node_track_caller_noprof (./include/linux/kmemleak.h:43)
	kmemdup_noprof (mm/util.c:136)
	ax25_rt_autobind (net/ax25/ax25_route.c:428)
	ax25_connect (net/ax25/af_ax25.c:1282)
	__sys_connect_file (net/socket.c:2045)
	__sys_connect (net/socket.c:2064)
	__x64_sys_connect (net/socket.c:2067)
	do_syscall_64 (arch/x86/entry/common.c:52 arch/x86/entry/common.c:83)
	entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:130)
	================================================================

	When socket is bound, refcounts must be incremented the way it is done
	in ax25_bind() and ax25_setsockopt() (SO_BINDTODEVICE). In case of
	autobind, the refcounts are not incremented.

	This bug leads to the following issue reported by Syzkaller:

	================================================================
	ax25_connect(): syz-executor318 uses autobind, please contact jreuter@yaina.de
	------------[ cut here ]------------
	refcount_t: decrement hit 0; leaking memory.
	WARNING: CPU: 0 PID: 5317 at lib/refcount.c:31 refcount_warn_saturate+0xfa/0x1d0 lib/refcount.c:31
	Modules linked in:
	CPU: 0 UID: 0 PID: 5317 Comm: syz-executor318 Not tainted 6.14.0-rc4-syzkaller-00278-gece144f151ac #0
	Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
	RIP: 0010:refcount_warn_saturate+0xfa/0x1d0 lib/refcount.c:31
	...
	Call Trace:
	<TASK>
	__refcount_dec include/linux/refcount.h:336 [inline]
	refcount_dec include/linux/refcount.h:351 [inline]
	ref_tracker_free+0x6af/0x7e0 lib/ref_tracker.c:236
	netdev_tracker_free include/linux/netdevice.h:4302 [inline]
	netdev_put include/linux/netdevice.h:4319 [inline]
	ax25_release+0x368/0x960 net/ax25/af_ax25.c:1080
	__sock_release net/socket.c:647 [inline]
	sock_close+0xbc/0x240 net/socket.c:1398
	__fput+0x3e9/0x9f0 fs/file_table.c:464
	__do_sys_close fs/open.c:1580 [inline]
	__se_sys_close fs/open.c:1565 [inline]
	__x64_sys_close+0x7f/0x110 fs/open.c:1565
	do_syscall_x64 arch/x86/entry/common.c:52 [inline]
	do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
	entry_SYSCALL_64_after_hwframe+0x77/0x7f
	...
	</TASK>
	================================================================

	Considering the issues above and the comments left in the code that say:
	"check if we can remove this feature. It is broken."; "autobinding in this
	may or may not work"; - it is better to completely remove this feature than
	to fix it because it is broken and leads to various kinds of memory bugs.

	Now calling connect() without first binding socket will result in an
	error (-EINVAL). Userspace software that relies on the autobind feature
	might get broken. However, this feature does not seem widely used with
	this specific driver as it was not reliable at any point of time, and it
	is already broken anyway. E.g. ax25-tools and ax25-apps packages for
	popular distributions do not use the autobind feature for AF_AX25.

	Found by Linux Verification Center (linuxtesting.org) with Syzkaller.

	The Linux kernel CVE team has assigned CVE-2025-22109 to this issue.


	Affected and fixed versions
	===========================

	Issue introduced in 2.6.12 with commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 and fixed in 6.14.2 with commit 61203fdd3e35519db9a98b6ff8983c620ffc4696
	Issue introduced in 2.6.12 with commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 and fixed in 6.15 with commit 2f6efbabceb6b2914ee9bafb86d9a51feae9cce8

	Please see https://www.kernel.org for a full list of currently supported
	kernel versions by the kernel community.

	Unaffected versions might change over time as fixes are backported to
	older supported kernel versions. The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2025-22109
	will be updated if fixes are backported, please check that for the most
	up to date information about this issue.


	Affected files
	==============

	The file(s) affected by this issue are:
	include/net/ax25.h
	net/ax25/af_ax25.c
	net/ax25/ax25_route.c


	Mitigation
	==========

	The Linux kernel CVE team recommends that you update to the latest
	stable kernel version for this, and many other bugfixes. Individual
	changes are never tested alone, but rather are part of a larger kernel
	release. Cherry-picking individual commits is not recommended or
	supported by the Linux kernel community at all. If however, updating to
	the latest release is impossible, the individual changes to resolve this
	issue can be found at these commits:
	https://git.kernel.org/stable/c/61203fdd3e35519db9a98b6ff8983c620ffc4696
	https://git.kernel.org/stable/c/2f6efbabceb6b2914ee9bafb86d9a51feae9cce8