| From bippy-5f407fcff5a0 Mon Sep 17 00:00:00 2001 |
| From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| To: <linux-cve-announce@vger.kernel.org> |
| Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org> |
| Subject: CVE-2022-48865: tipc: fix kernel panic when enabling bearer |
| |
| Description |
| =========== |
| |
| In the Linux kernel, the following vulnerability has been resolved: |
| |
| tipc: fix kernel panic when enabling bearer |
| |
| When enabling a bearer on a node, a kernel panic is observed: |
| |
| [ 4.498085] RIP: 0010:tipc_mon_prep+0x4e/0x130 [tipc] |
| ... |
| [ 4.520030] Call Trace: |
| [ 4.520689] <IRQ> |
| [ 4.521236] tipc_link_build_proto_msg+0x375/0x750 [tipc] |
| [ 4.522654] tipc_link_build_state_msg+0x48/0xc0 [tipc] |
| [ 4.524034] __tipc_node_link_up+0xd7/0x290 [tipc] |
| [ 4.525292] tipc_rcv+0x5da/0x730 [tipc] |
| [ 4.526346] ? __netif_receive_skb_core+0xb7/0xfc0 |
| [ 4.527601] tipc_l2_rcv_msg+0x5e/0x90 [tipc] |
| [ 4.528737] __netif_receive_skb_list_core+0x20b/0x260 |
| [ 4.530068] netif_receive_skb_list_internal+0x1bf/0x2e0 |
| [ 4.531450] ? dev_gro_receive+0x4c2/0x680 |
| [ 4.532512] napi_complete_done+0x6f/0x180 |
| [ 4.533570] virtnet_poll+0x29c/0x42e [virtio_net] |
| ... |
| |
| The node in question is receiving activate messages in another |
| thread after changing bearer status to allow message sending/ |
| receiving in current thread: |
| |
| thread 1 | thread 2 |
| -------- | -------- |
| | |
| tipc_enable_bearer() | |
| test_and_set_bit_lock() | |
| tipc_bearer_xmit_skb() | |
| | tipc_l2_rcv_msg() |
| | tipc_rcv() |
| | __tipc_node_link_up() |
| | tipc_link_build_state_msg() |
| | tipc_link_build_proto_msg() |
| | tipc_mon_prep() |
| | { |
| | ... |
| | // null-pointer dereference |
| | u16 gen = mon->dom_gen; |
| | ... |
| | } |
| // Not being executed yet | |
| tipc_mon_create() | |
| { | |
| ... | |
| // allocate | |
| mon = kzalloc(); | |
| ... | |
| } | |
| |
| Monitoring pointer in thread 2 is dereferenced before monitoring data |
| is allocated in thread 1. This causes kernel panic. |
| |
| This commit fixes it by allocating the monitoring data before enabling |
| the bearer to receive messages. |
| |
| The Linux kernel CVE team has assigned CVE-2022-48865 to this issue. |
| |
| |
| Affected and fixed versions |
| =========================== |
| |
| Issue introduced in 4.8 with commit 35c55c9877f8de0ab129fa1a309271d0ecc868b9 and fixed in 5.10.106 with commit 2de76d37d4a6dca9b96ea51da24d4290e6cfa1a5 |
| Issue introduced in 4.8 with commit 35c55c9877f8de0ab129fa1a309271d0ecc868b9 and fixed in 5.15.29 with commit f96dc3adb9a97b8f3dfdb88796483491a3006b71 |
| Issue introduced in 4.8 with commit 35c55c9877f8de0ab129fa1a309271d0ecc868b9 and fixed in 5.16.15 with commit f4f59fdbc748805b08c13dae14c01f0518c77c94 |
| Issue introduced in 4.8 with commit 35c55c9877f8de0ab129fa1a309271d0ecc868b9 and fixed in 5.17 with commit be4977b847f5d5cedb64d50eaaf2218c3a55a3a3 |
| |
| Please see https://www.kernel.org for a full list of currently supported |
| kernel versions by the kernel community. |
| |
| Unaffected versions might change over time as fixes are backported to |
| older supported kernel versions. The official CVE entry at |
| https://cve.org/CVERecord/?id=CVE-2022-48865 |
| will be updated if fixes are backported, please check that for the most |
| up to date information about this issue. |
| |
| |
| Affected files |
| ============== |
| |
| The file(s) affected by this issue are: |
| net/tipc/bearer.c |
| |
| |
| Mitigation |
| ========== |
| |
| The Linux kernel CVE team recommends that you update to the latest |
| stable kernel version for this, and many other bugfixes. Individual |
| changes are never tested alone, but rather are part of a larger kernel |
| release. Cherry-picking individual commits is not recommended or |
| supported by the Linux kernel community at all. If however, updating to |
| the latest release is impossible, the individual changes to resolve this |
| issue can be found at these commits: |
| https://git.kernel.org/stable/c/2de76d37d4a6dca9b96ea51da24d4290e6cfa1a5 |
| https://git.kernel.org/stable/c/f96dc3adb9a97b8f3dfdb88796483491a3006b71 |
| https://git.kernel.org/stable/c/f4f59fdbc748805b08c13dae14c01f0518c77c94 |
| https://git.kernel.org/stable/c/be4977b847f5d5cedb64d50eaaf2218c3a55a3a3 |