| From bippy-5f407fcff5a0 Mon Sep 17 00:00:00 2001 |
| From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| To: <linux-cve-announce@vger.kernel.org> |
| Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org> |
| Subject: CVE-2022-49146: virtio: use virtio_device_ready() in virtio_device_restore() |
| |
| Description |
| =========== |
| |
| In the Linux kernel, the following vulnerability has been resolved: |
| |
| virtio: use virtio_device_ready() in virtio_device_restore() |
| |
| After waking up a suspended VM, the kernel prints the following trace |
| for virtio drivers which do not directly call virtio_device_ready() in |
| the .restore: |
| |
| PM: suspend exit |
| irq 22: nobody cared (try booting with the "irqpoll" option) |
| Call Trace: |
| <IRQ> |
| dump_stack_lvl+0x38/0x49 |
| dump_stack+0x10/0x12 |
| __report_bad_irq+0x3a/0xaf |
| note_interrupt.cold+0xb/0x60 |
| handle_irq_event+0x71/0x80 |
| handle_fasteoi_irq+0x95/0x1e0 |
| __common_interrupt+0x6b/0x110 |
| common_interrupt+0x63/0xe0 |
| asm_common_interrupt+0x1e/0x40 |
| ? __do_softirq+0x75/0x2f3 |
| irq_exit_rcu+0x93/0xe0 |
| sysvec_apic_timer_interrupt+0xac/0xd0 |
| </IRQ> |
| <TASK> |
| asm_sysvec_apic_timer_interrupt+0x12/0x20 |
| arch_cpu_idle+0x12/0x20 |
| default_idle_call+0x39/0xf0 |
| do_idle+0x1b5/0x210 |
| cpu_startup_entry+0x20/0x30 |
| start_secondary+0xf3/0x100 |
| secondary_startup_64_no_verify+0xc3/0xcb |
| </TASK> |
| handlers: |
| [<000000008f9bac49>] vp_interrupt |
| [<000000008f9bac49>] vp_interrupt |
| Disabling IRQ #22 |
| |
| This happens because we don't invoke .enable_cbs callback in |
| virtio_device_restore(). That callback is used by some transports |
| (e.g. virtio-pci) to enable interrupts. |
| |
| Let's fix it, by calling virtio_device_ready() as we do in |
| virtio_dev_probe(). This function calls .enable_cts callback and sets |
| DRIVER_OK status bit. |
| |
| This fix also avoids setting DRIVER_OK twice for those drivers that |
| call virtio_device_ready() in the .restore. |
| |
| The Linux kernel CVE team has assigned CVE-2022-49146 to this issue. |
| |
| |
| Affected and fixed versions |
| =========================== |
| |
| Issue introduced in 5.16 with commit d50497eb4e554e1f0351e1836ee7241c059592e6 and fixed in 5.16.19 with commit 94e9f5da39ee5f8ea31be1585de31c54f10dedce |
| Issue introduced in 5.16 with commit d50497eb4e554e1f0351e1836ee7241c059592e6 and fixed in 5.17.2 with commit 4ae431113179d72c668b61df320af0c06d1aa5c5 |
| Issue introduced in 5.16 with commit d50497eb4e554e1f0351e1836ee7241c059592e6 and fixed in 5.18 with commit 8d65bc9a5be3f23c5e2ab36b6b8ef40095165b18 |
| |
| Please see https://www.kernel.org for a full list of currently supported |
| kernel versions by the kernel community. |
| |
| Unaffected versions might change over time as fixes are backported to |
| older supported kernel versions. The official CVE entry at |
| https://cve.org/CVERecord/?id=CVE-2022-49146 |
| will be updated if fixes are backported, please check that for the most |
| up to date information about this issue. |
| |
| |
| Affected files |
| ============== |
| |
| The file(s) affected by this issue are: |
| drivers/virtio/virtio.c |
| |
| |
| Mitigation |
| ========== |
| |
| The Linux kernel CVE team recommends that you update to the latest |
| stable kernel version for this, and many other bugfixes. Individual |
| changes are never tested alone, but rather are part of a larger kernel |
| release. Cherry-picking individual commits is not recommended or |
| supported by the Linux kernel community at all. If however, updating to |
| the latest release is impossible, the individual changes to resolve this |
| issue can be found at these commits: |
| https://git.kernel.org/stable/c/94e9f5da39ee5f8ea31be1585de31c54f10dedce |
| https://git.kernel.org/stable/c/4ae431113179d72c668b61df320af0c06d1aa5c5 |
| https://git.kernel.org/stable/c/8d65bc9a5be3f23c5e2ab36b6b8ef40095165b18 |
