cve/published/2022/CVE-2022-49518.mbox

From bippy-5f407fcff5a0 Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: <linux-cve-announce@vger.kernel.org>
Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: CVE-2022-49518: ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

ASoC: SOF: ipc3-topology: Correct get_control_data for non bytes payload

It is possible to craft a topology where sof_get_control_data() would do
out of bounds access because it expects that it is only called when the
payload is bytes type.
Confusingly it also handles other types of controls, but the payload
parsing implementation is only valid for bytes.

Fix the code to count the non bytes controls and instead of storing a
pointer to sof_abi_hdr in sof_widget_data (which is only valid for bytes),
store the pointer to the data itself and add a new member to save the size
of the data.

In case of non bytes controls we store the pointer to the chanv itself,
which is just an array of values at the end.

In case of bytes control, drop the wrong cdata->data (wdata[i].pdata) check
against NULL since it is incorrect and invalid in this context.
The data is pointing to the end of cdata struct, so it should never be
null.

The Linux kernel CVE team has assigned CVE-2022-49518 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 5.18 with commit 7006d20e5e9d25c079a82e2bc0ea7e292fdea6e6 and fixed in 5.18.3 with commit 896b03bb7c7010042786cfae2115083d4c241dd3
	Issue introduced in 5.18 with commit 7006d20e5e9d25c079a82e2bc0ea7e292fdea6e6 and fixed in 5.19 with commit a962890a5a3cce903ff7c7a19fadee63ed9efdc7

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2022-49518
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	sound/soc/sof/ipc3-topology.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/896b03bb7c7010042786cfae2115083d4c241dd3
	https://git.kernel.org/stable/c/a962890a5a3cce903ff7c7a19fadee63ed9efdc7