cve/published/2023/CVE-2023-53028.mbox - pub/scm/linux/security/vulns - Git at Google

 From bippy-5f407fcff5a0 Mon Sep 17 00:00:00 2001
 From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 To: <linux-cve-announce@vger.kernel.org>
 Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org>
 Subject: CVE-2023-53028: Revert "wifi: mac80211: fix memory leak in ieee80211_if_add()"

 Description
 ===========

 In the Linux kernel, the following vulnerability has been resolved:

 Revert "wifi: mac80211: fix memory leak in ieee80211_if_add()"

 This reverts commit 13e5afd3d773c6fc6ca2b89027befaaaa1ea7293.

 ieee80211_if_free() is already called from free_netdev(ndev)
 because ndev->priv_destructor == ieee80211_if_free

 syzbot reported:

 general protection fault, probably for non-canonical address 0xdffffc0000000004: 0000 [#1] PREEMPT SMP KASAN
 KASAN: null-ptr-deref in range [0x0000000000000020-0x0000000000000027]
 CPU: 0 PID: 10041 Comm: syz-executor.0 Not tainted 6.2.0-rc2-syzkaller-00388-g55b98837e37d #0
 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
 RIP: 0010:pcpu_get_page_chunk mm/percpu.c:262 [inline]
 RIP: 0010:pcpu_chunk_addr_search mm/percpu.c:1619 [inline]
 RIP: 0010:free_percpu mm/percpu.c:2271 [inline]
 RIP: 0010:free_percpu+0x186/0x10f0 mm/percpu.c:2254
 Code: 80 3c 02 00 0f 85 f5 0e 00 00 48 8b 3b 48 01 ef e8 cf b3 0b 00 48 ba 00 00 00 00 00 fc ff df 48 8d 78 20 48 89 f9 48 c1 e9 03 <80> 3c 11 00 0f 85 3b 0e 00 00 48 8b 58 20 48 b8 00 00 00 00 00 fc
 RSP: 0018:ffffc90004ba7068 EFLAGS: 00010002
 RAX: 0000000000000000 RBX: ffff88823ffe2b80 RCX: 0000000000000004
 RDX: dffffc0000000000 RSI: ffffffff81c1f4e7 RDI: 0000000000000020
 RBP: ffffe8fffe8fc220 R08: 0000000000000005 R09: 0000000000000000
 R10: 0000000000000000 R11: 1ffffffff2179ab2 R12: ffff8880b983d000
 R13: 0000000000000003 R14: 0000607f450fc220 R15: ffff88823ffe2988
 FS: 00007fcb349de700(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 CR2: 0000001b32220000 CR3: 000000004914f000 CR4: 00000000003506f0
 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
 Call Trace:
 <TASK>
 netdev_run_todo+0x6bf/0x1100 net/core/dev.c:10352
 ieee80211_register_hw+0x2663/0x4040 net/mac80211/main.c:1411
 mac80211_hwsim_new_radio+0x2537/0x4d80 drivers/net/wireless/mac80211_hwsim.c:4583
 hwsim_new_radio_nl+0xa09/0x10f0 drivers/net/wireless/mac80211_hwsim.c:5176
 genl_family_rcv_msg_doit.isra.0+0x1e6/0x2d0 net/netlink/genetlink.c:968
 genl_family_rcv_msg net/netlink/genetlink.c:1048 [inline]
 genl_rcv_msg+0x4ff/0x7e0 net/netlink/genetlink.c:1065
 netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2564
 genl_rcv+0x28/0x40 net/netlink/genetlink.c:1076
 netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
 netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1356
 netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1932
 sock_sendmsg_nosec net/socket.c:714 [inline]
 sock_sendmsg+0xd3/0x120 net/socket.c:734
 ____sys_sendmsg+0x712/0x8c0 net/socket.c:2476
 ___sys_sendmsg+0x110/0x1b0 net/socket.c:2530
 __sys_sendmsg+0xf7/0x1c0 net/socket.c:2559
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

 The Linux kernel CVE team has assigned CVE-2023-53028 to this issue.


 Affected and fixed versions
 ===========================

 	Issue introduced in 5.10.163 with commit b2c0b94f48373ee743a4d63825a9d52364418837 and fixed in 5.10.165 with commit 71e5cd1018d345e649e63f74a56c1897f99db7e9
 	Issue introduced in 5.15.86 with commit 2e32f1299814e8aa2e75aa58704543a36ea3e201 and fixed in 5.15.90 with commit 982c8b1e95c088f5d8f65967ec25be66e961401c
 	Issue introduced in 6.1.2 with commit 9a50a7f64243bd21a84353c371f3977b9ffd9fa5 and fixed in 6.1.8 with commit effecd8d116d3d3a28b4f628e61bba8d318fdfcf
 	Issue introduced in 6.0.16 with commit 147537737a3c83e07a5295de38424c21d354d2a4

 Please see https://www.kernel.org for a full list of currently supported
 kernel versions by the kernel community.

 Unaffected versions might change over time as fixes are backported to
 older supported kernel versions.  The official CVE entry at
 	https://cve.org/CVERecord/?id=CVE-2023-53028
 will be updated if fixes are backported, please check that for the most
 up to date information about this issue.


 Affected files
 ==============

 The file(s) affected by this issue are:
 	net/mac80211/iface.c


 Mitigation
 ==========

 The Linux kernel CVE team recommends that you update to the latest
 stable kernel version for this, and many other bugfixes.  Individual
 changes are never tested alone, but rather are part of a larger kernel
 release.  Cherry-picking individual commits is not recommended or
 supported by the Linux kernel community at all.  If however, updating to
 the latest release is impossible, the individual changes to resolve this
 issue can be found at these commits:
 	https://git.kernel.org/stable/c/71e5cd1018d345e649e63f74a56c1897f99db7e9
 	https://git.kernel.org/stable/c/982c8b1e95c088f5d8f65967ec25be66e961401c
 	https://git.kernel.org/stable/c/effecd8d116d3d3a28b4f628e61bba8d318fdfcf
 	https://git.kernel.org/stable/c/80f8a66dede0a4b4e9e846765a97809c6fe49ce5
	From bippy-5f407fcff5a0 Mon Sep 17 00:00:00 2001
	From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
	To: <linux-cve-announce@vger.kernel.org>
	Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org>
	Subject: CVE-2023-53028: Revert "wifi: mac80211: fix memory leak in ieee80211_if_add()"

	Description
	===========

	In the Linux kernel, the following vulnerability has been resolved:

	Revert "wifi: mac80211: fix memory leak in ieee80211_if_add()"

	This reverts commit 13e5afd3d773c6fc6ca2b89027befaaaa1ea7293.

	ieee80211_if_free() is already called from free_netdev(ndev)
	because ndev->priv_destructor == ieee80211_if_free

	syzbot reported:

	general protection fault, probably for non-canonical address 0xdffffc0000000004: 0000 [#1] PREEMPT SMP KASAN
	KASAN: null-ptr-deref in range [0x0000000000000020-0x0000000000000027]
	CPU: 0 PID: 10041 Comm: syz-executor.0 Not tainted 6.2.0-rc2-syzkaller-00388-g55b98837e37d #0
	Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
	RIP: 0010:pcpu_get_page_chunk mm/percpu.c:262 [inline]
	RIP: 0010:pcpu_chunk_addr_search mm/percpu.c:1619 [inline]
	RIP: 0010:free_percpu mm/percpu.c:2271 [inline]
	RIP: 0010:free_percpu+0x186/0x10f0 mm/percpu.c:2254
	Code: 80 3c 02 00 0f 85 f5 0e 00 00 48 8b 3b 48 01 ef e8 cf b3 0b 00 48 ba 00 00 00 00 00 fc ff df 48 8d 78 20 48 89 f9 48 c1 e9 03 <80> 3c 11 00 0f 85 3b 0e 00 00 48 8b 58 20 48 b8 00 00 00 00 00 fc
	RSP: 0018:ffffc90004ba7068 EFLAGS: 00010002
	RAX: 0000000000000000 RBX: ffff88823ffe2b80 RCX: 0000000000000004
	RDX: dffffc0000000000 RSI: ffffffff81c1f4e7 RDI: 0000000000000020
	RBP: ffffe8fffe8fc220 R08: 0000000000000005 R09: 0000000000000000
	R10: 0000000000000000 R11: 1ffffffff2179ab2 R12: ffff8880b983d000
	R13: 0000000000000003 R14: 0000607f450fc220 R15: ffff88823ffe2988
	FS: 00007fcb349de700(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
	CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
	CR2: 0000001b32220000 CR3: 000000004914f000 CR4: 00000000003506f0
	DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
	DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
	Call Trace:
	<TASK>
	netdev_run_todo+0x6bf/0x1100 net/core/dev.c:10352
	ieee80211_register_hw+0x2663/0x4040 net/mac80211/main.c:1411
	mac80211_hwsim_new_radio+0x2537/0x4d80 drivers/net/wireless/mac80211_hwsim.c:4583
	hwsim_new_radio_nl+0xa09/0x10f0 drivers/net/wireless/mac80211_hwsim.c:5176
	genl_family_rcv_msg_doit.isra.0+0x1e6/0x2d0 net/netlink/genetlink.c:968
	genl_family_rcv_msg net/netlink/genetlink.c:1048 [inline]
	genl_rcv_msg+0x4ff/0x7e0 net/netlink/genetlink.c:1065
	netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2564
	genl_rcv+0x28/0x40 net/netlink/genetlink.c:1076
	netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
	netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1356
	netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1932
	sock_sendmsg_nosec net/socket.c:714 [inline]
	sock_sendmsg+0xd3/0x120 net/socket.c:734
	____sys_sendmsg+0x712/0x8c0 net/socket.c:2476
	___sys_sendmsg+0x110/0x1b0 net/socket.c:2530
	__sys_sendmsg+0xf7/0x1c0 net/socket.c:2559
	do_syscall_x64 arch/x86/entry/common.c:50 [inline]
	do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
	entry_SYSCALL_64_after_hwframe+0x63/0xcd

	The Linux kernel CVE team has assigned CVE-2023-53028 to this issue.


	Affected and fixed versions
	===========================

	Issue introduced in 5.10.163 with commit b2c0b94f48373ee743a4d63825a9d52364418837 and fixed in 5.10.165 with commit 71e5cd1018d345e649e63f74a56c1897f99db7e9
	Issue introduced in 5.15.86 with commit 2e32f1299814e8aa2e75aa58704543a36ea3e201 and fixed in 5.15.90 with commit 982c8b1e95c088f5d8f65967ec25be66e961401c
	Issue introduced in 6.1.2 with commit 9a50a7f64243bd21a84353c371f3977b9ffd9fa5 and fixed in 6.1.8 with commit effecd8d116d3d3a28b4f628e61bba8d318fdfcf
	Issue introduced in 6.0.16 with commit 147537737a3c83e07a5295de38424c21d354d2a4

	Please see https://www.kernel.org for a full list of currently supported
	kernel versions by the kernel community.

	Unaffected versions might change over time as fixes are backported to
	older supported kernel versions. The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2023-53028
	will be updated if fixes are backported, please check that for the most
	up to date information about this issue.


	Affected files
	==============

	The file(s) affected by this issue are:
	net/mac80211/iface.c


	Mitigation
	==========

	The Linux kernel CVE team recommends that you update to the latest
	stable kernel version for this, and many other bugfixes. Individual
	changes are never tested alone, but rather are part of a larger kernel
	release. Cherry-picking individual commits is not recommended or
	supported by the Linux kernel community at all. If however, updating to
	the latest release is impossible, the individual changes to resolve this
	issue can be found at these commits:
	https://git.kernel.org/stable/c/71e5cd1018d345e649e63f74a56c1897f99db7e9
	https://git.kernel.org/stable/c/982c8b1e95c088f5d8f65967ec25be66e961401c
	https://git.kernel.org/stable/c/effecd8d116d3d3a28b4f628e61bba8d318fdfcf
	https://git.kernel.org/stable/c/80f8a66dede0a4b4e9e846765a97809c6fe49ce5