cve/published/2024/CVE-2024-57902.mbox

From bippy-5f407fcff5a0 Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: <linux-cve-announce@vger.kernel.org>
Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: CVE-2024-57902: af_packet: fix vlan_get_tci() vs MSG_PEEK

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

af_packet: fix vlan_get_tci() vs MSG_PEEK

Blamed commit forgot MSG_PEEK case, allowing a crash [1] as found
by syzbot.

Rework vlan_get_tci() to not touch skb at all,
so that it can be used from many cpus on the same skb.

Add a const qualifier to skb argument.

[1]
skbuff: skb_under_panic: text:ffffffff8a8da482 len:32 put:14 head:ffff88807a1d5800 data:ffff88807a1d5810 tail:0x14 end:0x140 dev:<NULL>
------------[ cut here ]------------
 kernel BUG at net/core/skbuff.c:206 !
Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI
CPU: 0 UID: 0 PID: 5880 Comm: syz-executor172 Not tainted 6.13.0-rc3-syzkaller-00762-g9268abe611b0 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
 RIP: 0010:skb_panic net/core/skbuff.c:206 [inline]
 RIP: 0010:skb_under_panic+0x14b/0x150 net/core/skbuff.c:216
Code: 0b 8d 48 c7 c6 9e 6c 26 8e 48 8b 54 24 08 8b 0c 24 44 8b 44 24 04 4d 89 e9 50 41 54 41 57 41 56 e8 3a 5a 79 f7 48 83 c4 20 90 <0f> 0b 0f 1f 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 f3
RSP: 0018:ffffc90003baf5b8 EFLAGS: 00010286
RAX: 0000000000000087 RBX: dffffc0000000000 RCX: 8565c1eec37aa000
RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
RBP: ffff88802616fb50 R08: ffffffff817f0a4c R09: 1ffff92000775e50
R10: dffffc0000000000 R11: fffff52000775e51 R12: 0000000000000140
R13: ffff88807a1d5800 R14: ffff88807a1d5810 R15: 0000000000000014
FS:  00007fa03261f6c0(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007ffd65753000 CR3: 0000000031720000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
  skb_push+0xe5/0x100 net/core/skbuff.c:2636
  vlan_get_tci+0x272/0x550 net/packet/af_packet.c:565
  packet_recvmsg+0x13c9/0x1ef0 net/packet/af_packet.c:3616
  sock_recvmsg_nosec net/socket.c:1044 [inline]
  sock_recvmsg+0x22f/0x280 net/socket.c:1066
  ____sys_recvmsg+0x1c6/0x480 net/socket.c:2814
  ___sys_recvmsg net/socket.c:2856 [inline]
  do_recvmmsg+0x426/0xab0 net/socket.c:2951
  __sys_recvmmsg net/socket.c:3025 [inline]
  __do_sys_recvmmsg net/socket.c:3048 [inline]
  __se_sys_recvmmsg net/socket.c:3041 [inline]
  __x64_sys_recvmmsg+0x199/0x250 net/socket.c:3041
  do_syscall_x64 arch/x86/entry/common.c:52 [inline]
  do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83

The Linux kernel CVE team has assigned CVE-2024-57902 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 5.4.282 with commit c77064e76c768fb101ea5ff92dc771142fc9d8fd and fixed in 5.4.289 with commit 66ffb0cf2125dcf9e902eede4a43653a24fd9cb2
	Issue introduced in 5.10.224 with commit 83e2dfadcb6258fe3111c8a8ec9cf34465e55e64 and fixed in 5.10.233 with commit fa57f07ba0622c8692f40e1300adca59277b0044
	Issue introduced in 5.15.165 with commit d0a1f9aa70f0d8a05b6320e8a3f3b83adab8dac3 and fixed in 5.15.176 with commit 65c67049e9ed481f6b52264b39618b8c6dfb1d3e
	Issue introduced in 6.1.103 with commit 5839f59ff1dd4e35b9e767927931a039484839e1 and fixed in 6.1.124 with commit d91b4a9baa018a001d5c884e236c0cfd31f9f4a1
	Issue introduced in 6.6.44 with commit 5a041d25b67042cbe06a0fb292ee22fd1147e65c and fixed in 6.6.70 with commit 7aa78d0d8546d8ce5a764add3f55d72e707c18f1
	Issue introduced in 6.11 with commit 79eecf631c14e7f4057186570ac20e2cfac3802e and fixed in 6.12.9 with commit b65292a548d847099a4fe0fff53122a06e798e25
	Issue introduced in 6.11 with commit 79eecf631c14e7f4057186570ac20e2cfac3802e and fixed in 6.13 with commit 77ee7a6d16b6ec07b5c3ae2b6b60a24c1afbed09
	Issue introduced in 4.19.320 with commit 3dfd84aa72fa7329ed4a257c8f40e0c9aff4dc8f
	Issue introduced in 6.10.3 with commit 66f23a7b5174b5d3e7111fd2d0d5a4f3faaa12e5

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2024-57902
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	net/packet/af_packet.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/66ffb0cf2125dcf9e902eede4a43653a24fd9cb2
	https://git.kernel.org/stable/c/fa57f07ba0622c8692f40e1300adca59277b0044
	https://git.kernel.org/stable/c/65c67049e9ed481f6b52264b39618b8c6dfb1d3e
	https://git.kernel.org/stable/c/d91b4a9baa018a001d5c884e236c0cfd31f9f4a1
	https://git.kernel.org/stable/c/7aa78d0d8546d8ce5a764add3f55d72e707c18f1
	https://git.kernel.org/stable/c/b65292a548d847099a4fe0fff53122a06e798e25
	https://git.kernel.org/stable/c/77ee7a6d16b6ec07b5c3ae2b6b60a24c1afbed09