cve/published/2024/CVE-2024-57984.mbox

From bippy-5f407fcff5a0 Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: <linux-cve-announce@vger.kernel.org>
Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: CVE-2024-57984: i3c: dw: Fix use-after-free in dw_i3c_master driver due to race condition

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

i3c: dw: Fix use-after-free in dw_i3c_master driver due to race condition

In dw_i3c_common_probe, &master->hj_work is bound with
dw_i3c_hj_work. And dw_i3c_master_irq_handler can call
dw_i3c_master_irq_handle_ibis function to start the work.

If we remove the module which will call dw_i3c_common_remove to
make cleanup, it will free master->base through i3c_master_unregister
while the work mentioned above will be used. The sequence of operations
that may lead to a UAF bug is as follows:

CPU0                                      CPU1

                                     | dw_i3c_hj_work
dw_i3c_common_remove                 |
i3c_master_unregister(&master->base) |
device_unregister(&master->dev)      |
device_release                       |
//free master->base                  |
                                     | i3c_master_do_daa(&master->base)
                                     | //use master->base

Fix it by ensuring that the work is canceled before proceeding with
the cleanup in dw_i3c_common_remove.

The Linux kernel CVE team has assigned CVE-2024-57984 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 5.0 with commit 1dd728f5d4d4b8b53196c1e0fcf86bbaaee39cef and fixed in 6.6.76 with commit 60d2fb033a999bb644f8e8606ff4a1b82de36c6f
	Issue introduced in 5.0 with commit 1dd728f5d4d4b8b53196c1e0fcf86bbaaee39cef and fixed in 6.12.13 with commit 9b0063098fcde17cd2894f2c96459b23388507ca
	Issue introduced in 5.0 with commit 1dd728f5d4d4b8b53196c1e0fcf86bbaaee39cef and fixed in 6.13.2 with commit fc84dd3c909a372c0d130f5f84c404717c17eed8
	Issue introduced in 5.0 with commit 1dd728f5d4d4b8b53196c1e0fcf86bbaaee39cef and fixed in 6.14 with commit b75439c945b94dd8a2b645355bdb56f948052601

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2024-57984
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/i3c/master/dw-i3c-master.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/60d2fb033a999bb644f8e8606ff4a1b82de36c6f
	https://git.kernel.org/stable/c/9b0063098fcde17cd2894f2c96459b23388507ca
	https://git.kernel.org/stable/c/fc84dd3c909a372c0d130f5f84c404717c17eed8
	https://git.kernel.org/stable/c/b75439c945b94dd8a2b645355bdb56f948052601