| From bippy-5f407fcff5a0 Mon Sep 17 00:00:00 2001 |
| From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| To: <linux-cve-announce@vger.kernel.org> |
| Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org> |
| Subject: CVE-2024-57985: firmware: qcom: scm: Cleanup global '__scm' on probe failures |
| |
| Description |
| =========== |
| |
| In the Linux kernel, the following vulnerability has been resolved: |
| |
| firmware: qcom: scm: Cleanup global '__scm' on probe failures |
| |
| If SCM driver fails the probe, it should not leave global '__scm' |
| variable assigned, because external users of this driver will assume the |
| probe finished successfully. For example TZMEM parts ('__scm->mempool') |
| are initialized later in the probe, but users of it (__scm_smc_call()) |
| rely on the '__scm' variable. |
| |
| This fixes theoretical NULL pointer exception, triggered via introducing |
| probe deferral in SCM driver with call trace: |
| |
| qcom_tzmem_alloc+0x70/0x1ac (P) |
| qcom_tzmem_alloc+0x64/0x1ac (L) |
| qcom_scm_assign_mem+0x78/0x194 |
| qcom_rmtfs_mem_probe+0x2d4/0x38c |
| platform_probe+0x68/0xc8 |
| |
| The Linux kernel CVE team has assigned CVE-2024-57985 to this issue. |
| |
| |
| Affected and fixed versions |
| =========================== |
| |
| Issue introduced in 6.11 with commit 40289e35ca525f29a03989352ab207b6a9675475 and fixed in 6.12.13 with commit 390d3baeba51a126f75c97b90ec28b9384ce4b84 |
| Issue introduced in 6.11 with commit 40289e35ca525f29a03989352ab207b6a9675475 and fixed in 6.13.2 with commit faf1715798fe72b79e4432ce8c6d03ca69765425 |
| Issue introduced in 6.11 with commit 40289e35ca525f29a03989352ab207b6a9675475 and fixed in 6.14 with commit 1e76b546e6fca7eb568161f408133904ca6bcf4f |
| |
| Please see https://www.kernel.org for a full list of currently supported |
| kernel versions by the kernel community. |
| |
| Unaffected versions might change over time as fixes are backported to |
| older supported kernel versions. The official CVE entry at |
| https://cve.org/CVERecord/?id=CVE-2024-57985 |
| will be updated if fixes are backported, please check that for the most |
| up to date information about this issue. |
| |
| |
| Affected files |
| ============== |
| |
| The file(s) affected by this issue are: |
| drivers/firmware/qcom/qcom_scm.c |
| |
| |
| Mitigation |
| ========== |
| |
| The Linux kernel CVE team recommends that you update to the latest |
| stable kernel version for this, and many other bugfixes. Individual |
| changes are never tested alone, but rather are part of a larger kernel |
| release. Cherry-picking individual commits is not recommended or |
| supported by the Linux kernel community at all. If however, updating to |
| the latest release is impossible, the individual changes to resolve this |
| issue can be found at these commits: |
| https://git.kernel.org/stable/c/390d3baeba51a126f75c97b90ec28b9384ce4b84 |
| https://git.kernel.org/stable/c/faf1715798fe72b79e4432ce8c6d03ca69765425 |
| https://git.kernel.org/stable/c/1e76b546e6fca7eb568161f408133904ca6bcf4f |