| From bippy-1.1.0 Mon Sep 17 00:00:00 2001 |
| From: Greg Kroah-Hartman <gregkh@kernel.org> |
| To: <linux-cve-announce@vger.kernel.org> |
| Reply-to: <cve@kernel.org>, <linux-kernel@vger.kernel.org> |
| Subject: CVE-2024-58099: vmxnet3: Fix packet corruption in vmxnet3_xdp_xmit_frame |
| |
| Description |
| =========== |
| |
| In the Linux kernel, the following vulnerability has been resolved: |
| |
| vmxnet3: Fix packet corruption in vmxnet3_xdp_xmit_frame |
| |
| Andrew and Nikolay reported connectivity issues with Cilium's service |
| load-balancing in case of vmxnet3. |
| |
| If a BPF program for native XDP adds an encapsulation header such as |
| IPIP and transmits the packet out the same interface, then in case |
| of vmxnet3 a corrupted packet is being sent and subsequently dropped |
| on the path. |
| |
| vmxnet3_xdp_xmit_frame() which is called e.g. via vmxnet3_run_xdp() |
| through vmxnet3_xdp_xmit_back() calculates an incorrect DMA address: |
| |
| page = virt_to_page(xdpf->data); |
| tbi->dma_addr = page_pool_get_dma_addr(page) + |
| VMXNET3_XDP_HEADROOM; |
| dma_sync_single_for_device(&adapter->pdev->dev, |
| tbi->dma_addr, buf_size, |
| DMA_TO_DEVICE); |
| |
| The above assumes a fixed offset (VMXNET3_XDP_HEADROOM), but the XDP |
| BPF program could have moved xdp->data. While the passed buf_size is |
| correct (xdpf->len), the dma_addr needs to have a dynamic offset which |
| can be calculated as xdpf->data - (void *)xdpf, that is, xdp->data - |
| xdp->data_hard_start. |
| |
| The Linux kernel CVE team has assigned CVE-2024-58099 to this issue. |
| |
| |
| Affected and fixed versions |
| =========================== |
| |
| Issue introduced in 6.6 with commit 54f00cce11786742bd11e5e68c3bf85e6dc048c9 and fixed in 6.6.59 with commit 59ba6cdadb9c26b606a365eb9c9b25eb2052622d |
| Issue introduced in 6.6 with commit 54f00cce11786742bd11e5e68c3bf85e6dc048c9 and fixed in 6.11.6 with commit f82eb34fb59a8fb96c19f4f492c20eb774140bb5 |
| Issue introduced in 6.6 with commit 54f00cce11786742bd11e5e68c3bf85e6dc048c9 and fixed in 6.12 with commit 4678adf94da4a9e9683817b246b58ce15fb81782 |
| |
| Please see https://www.kernel.org for a full list of currently supported |
| kernel versions by the kernel community. |
| |
| Unaffected versions might change over time as fixes are backported to |
| older supported kernel versions. The official CVE entry at |
| https://cve.org/CVERecord/?id=CVE-2024-58099 |
| will be updated if fixes are backported, please check that for the most |
| up to date information about this issue. |
| |
| |
| Affected files |
| ============== |
| |
| The file(s) affected by this issue are: |
| drivers/net/vmxnet3/vmxnet3_xdp.c |
| |
| |
| Mitigation |
| ========== |
| |
| The Linux kernel CVE team recommends that you update to the latest |
| stable kernel version for this, and many other bugfixes. Individual |
| changes are never tested alone, but rather are part of a larger kernel |
| release. Cherry-picking individual commits is not recommended or |
| supported by the Linux kernel community at all. If however, updating to |
| the latest release is impossible, the individual changes to resolve this |
| issue can be found at these commits: |
| https://git.kernel.org/stable/c/59ba6cdadb9c26b606a365eb9c9b25eb2052622d |
| https://git.kernel.org/stable/c/f82eb34fb59a8fb96c19f4f492c20eb774140bb5 |
| https://git.kernel.org/stable/c/4678adf94da4a9e9683817b246b58ce15fb81782 |