iwd: Filter out connect failure for auto connect mode
If the user ask explicitly to connect to a network and the operations
fails for any reason the ConnMan core will go from either idle or
connected to failure state. In failure state the core will call
connman_network_disconnect() which will be propagated to iwd.
ConnMan will set the AutoConnect flag on KnownNetwork on
bootup/discovery. iwd tries interpretes this as request to connect
now. If this is not possible, e.g. out of reach, iwd response with an
failure. This disables the auto connect mode of iwd.
So the simplest thing here is not to tell the core the connect fails,
instead just don't do anything if auto connect is enabled. This keeps
the auto connect of iwd working and ConnMan's state machine doesn't
care either.
diff --git a/plugins/iwd.c b/plugins/iwd.c
index d5c1f88..4ba107f 100644
--- a/plugins/iwd.c
+++ b/plugins/iwd.c
@@ -249,7 +249,7 @@
if (!strcmp(dbus_error, "net.connman.iwd.Failed"))
connman_network_set_error(iwdn->network,
CONNMAN_NETWORK_ERROR_INVALID_KEY);
- else
+ else if (!iwdn->autoconnect)
connman_network_set_error(iwdn->network,
CONNMAN_NETWORK_ERROR_CONNECT_FAIL);
return;
